[NETCONF-510] Fix netconf-tcp and netconf-ssh activators Created: 23/Feb/18  Updated: 28/Feb/18  Resolved: 28/Feb/18

Status: Resolved
Project: netconf
Component/s: netconf
Affects Version/s: Oxygen
Fix Version/s: Oxygen

Type: Bug Priority: Highest
Reporter: Robert Varga Assignee: Ryan Goulding
Resolution: Done Votes: 0
Labels: patch_merged
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Duplicate
is duplicated by NETCONF-518 SFT failure in netconf/features/netco... Resolved

 Description   

Both of these activators have a dependency on netconf-util activating and exposing NetconfConfiguration, but this is not expressed in any way OSGi would understand and order the startup. This leads to sporadic failures to activate because netconf-util is scheduled to activate after netconf-ssh or netconf-tcp.

This is evidenced here:

https://logs.opendaylight.org/releng/vex-yul-odl-jenkins-1/autorelease-release-oxygen/184/console.log.gz

https://logs.opendaylight.org/releng/vex-yul-odl-jenkins-1/autorelease-release-oxygen/184/netconf/features/netconf/odl-netconf-ssh/target/surefire-reports/org.opendaylight.odlparent.featuretest.SingleFeatureTest-output.txt.gz

 

The simplest thing to do is to rewrite both netconf-ssh and netconf-tcp to use blueprint, so that the BP container starts only after netconf-util activates (i.e. NetconfConfiguration is published). Alternative is for the two activators to use a ServiceTracker – but that may prove too complex. In any case org.opendaylight.netconf.util.osgi.NetconfConfigUtil should be eliminated in the process.



 Comments   
Comment by Tom Pantelis [ 23/Feb/18 ]

There's already a patch to convert to BP: https://git.opendaylight.org/gerrit/#/c/61718/

Comment by Kit Lou [ 27/Feb/18 ]

Is 61718 the patch for this issue?  Please cherry pick to the oxygen branch and get a +2.  Thanks!

Comment by Kit Lou [ 28/Feb/18 ]

Patch to be merged per Ryan (https://lists.opendaylight.org/pipermail/release/2018-February/014143.html):

https://git.opendaylight.org/gerrit/#/c/68835/

Generated at Wed Feb 07 20:15:13 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.