[NETCONF-57] Extend sal-netconf-connector base schema context to include ietf-netconf-notifications Created: 06/Aug/15  Updated: 15/Mar/19  Resolved: 12/Feb/16

Status: Resolved
Project: netconf
Component/s: netconf
Affects Version/s: None
Fix Version/s: None

Type: Bug
Reporter: Tomas Cere Assignee: Andrej Mak
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All

External issue ID: 4100
Priority: Normal

 Description   

sal-netconf-connector has a base schema context that has base netconf schemas in case a device does not provide these, but no ietf-netconf-notificatons. This would be a nice addition, since we already encountered devices that do not provide this schema.

 Comments   
Comment by Rashmi Tomer [ 21/Oct/15 ]

Hi,

I was going through this bug to fix same.
Can you please elaborate more on this bug (like where is base schema context, bit more on ietf notifications that needs to be added, etc).

Are you looking for the addition of all notifications as defined in "ietf-netconf-notifications" module, in the existing augmentation of odl-sal-netconf-connector-cfg.yang ?

Thanks
Rashmi

Comment by Tomas Cere [ 21/Oct/15 ]

Hi,

base schema context is built here: https://github.com/opendaylight/netconf/blob/c84df3c3b3ccd14022c4e452eedcd9c54c8c928e/opendaylight/netconf/sal-netconf-connector/src/main/java/org/opendaylight/netconf/sal/connect/netconf/NetconfDevice.java#L78-L84

you should be able to just add it in the same way as ietf-netconf, you would just use the generated $YangModuleInfoImpl for the ietf-netconf-notifications binding.
Please take the bug and put it's status as in progress if you are working on it so there's no duplicate work. If you have any more questions ask .

Tomas

Comment by Rashmi Tomer [ 30/Oct/15 ]

Hi,

I have pushed in the patch in.
Could you please review it and revert back if anything I missed.

Here is the link :
https://git.opendaylight.org/gerrit/#/c/28935/

Thanks,
Rashmi

Comment by Maros Marsalek [ 02/Nov/15 ]

The fix should be ported to lithium as well.

Also I think the schema should only be included if the device exposes standard notification capability.

Comment by Rashmi Tomer [ 24/Dec/15 ]

Patch 3 submitted on the link below, so that the schema should only be included if the device exposes standard notification capability.

https://git.opendaylight.org/gerrit/#/c/28935/

I have created another context INIT_SCHEMA_CTX_WITH_IETF_NOTIFICATION for above scenario and it will be loaded only when the device have isNotificationsSupported true, when onRemoteSessionUp is invoked.

Please review it and let me know if the approach is fine or suggest me to make it better.

Comment by Tomas Cere [ 12/Feb/16 ]

https://git.opendaylight.org/gerrit/#/c/33758/

Generated at Wed Feb 07 20:14:03 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.