[NETCONF-579] Add a strongly typed internal (Java) RPC API for JSONRestconfService's subscribeToStream() Created: 01/Nov/18 Updated: 19/Mar/19 |
|
| Status: | Open |
| Project: | netconf |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Medium |
| Reporter: | Michael Vorburger | Assignee: | Josh Hershberg |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
This is a follow-up to https://git.opendaylight.org/gerrit/#/c/77273/ (re. NETVIRT-1460 & It seems strange to me that in that PortStatusUpdateInitializer, jhershbe apparently had to use JSONRestconfService's invokeRpc() on sal-remote:create-data-change-event-subscription with a SUBSCRIBE_JSON String. We'll merge that, but wouldn't be better if there was a clean strongly typed internal (Java) API for that instead of this weird architecture where neutron uses restconf to invoke an RPC like this? JMorvay is this something you would consider adding? |
| Comments |
| Comment by Michael Vorburger [ 01/Nov/18 ] |
|
jhershbe hey wait a second ... so this sal-remote:create-data-change-event-subscription RPC is from netconf/restconf/restconf-common-models/src/main/yang/opendaylight-md-sal-remote.yang. And so the org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.md.sal.remote.rev140114.SalRemoteService has a createDataChangeEventSubscription. So ... why did you do that handstand hoop via JSONRestconfService's invokeRpc() instead of just calling that RPC "as always" ? |
| Comment by Michael Vorburger [ 01/Nov/18 ] |
|
So https://git.opendaylight.org/gerrit/77410 uses the Java RPC for sal-remote:create-data-change-event-subscription ... BUT the subscribeToStream() (of JSONRestconfService is still lacking a Java RPC, and that's what this issues is really about (I initially got confused) .. JMorvay (or tpantelis) is that something you would like to add in restconf, some time? |
| Comment by Michael Vorburger [ 05/Nov/18 ] |
|
c/77410 can probably be restored when this is made available. |