[NETCONF-589] Get rid of JAXB in netconf-monitoring Created: 04/Jan/19 Updated: 30/Nov/21 Resolved: 31/Jan/19 |
|
| Status: | Resolved |
| Project: | netconf |
| Component/s: | netconf |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Medium |
| Reporter: | Robert Varga | Assignee: | Unassigned |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Description |
|
netconf-monitoring is the only component using JAXB, for whatever historic reasons. We should be constructing a document either manually or through XML codec. Evaluate which option is more feasible, including ditching binding representations, if they are not useful. |
| Comments |
| Comment by Jakub Morvay [ 07/Jan/19 ] |
|
Actually, we can remove the netconf-monitoring completely. We need to refactor out some classes used in mdsal-netconf-monitoring, others can be deleted (this also concerns the classes that are using JAXB). The only problem here is that also test-tool relays on netconf-monitoring. |
| Comment by Jakub Morvay [ 07/Jan/19 ] |
|
I prepared the removal of netconf-monitoring here: https://jira.opendaylight.org/browse/NETCONF-589. JAXB was used to construct netconf-state data for CSS netconf server. This is not needed anymore since we are not using CSS anymore, mdsal-netconf-monitoring creates netconf state manually and writes it to operational DS. So there is no need for JAXB on the netconf northbound side. However, netconf test tool (when running in dummy DS mode - md-sal option is set to false) depends on netconf-monitoring and its implementation of Get netconf operation (the one that actually using JAXB). So we should refactor test tool to manually construct its netconf state. Or we can get rid of this dummy DS mode completely and we don't have to care about that. Not sure if this dummy DS mode gives us any advantage over using real md-sal backed DS in test tool |
| Comment by Jakub Morvay [ 10/Jan/19 ] |
|
Patch [0] gets rid of JAXB in netconf-monitoring. It actually gets rid of the netconf-monitoring at all since it is not used anymore. GetSchema class is moved to mdsal-netconf-monitoring, some other classes used by netconf test-tool are moved into test-tool. Now we need to get rid of JAXB from netconf test-tool or live with it.. |
| Comment by Jakub Morvay [ 31/Jan/19 ] |
|
Closing this as netconf-monitoring does not exist anymore and the only place we are using and are dependent on JAXB is test-tool now. |