[NETCONF-862] Add changed-leaf-nodes-only subscription extension Created: 24/Feb/22  Updated: 26/Jul/23  Resolved: 02/Jan/23

Status: Resolved
Project: netconf
Component/s: restconf-nb
Affects Version/s: None
Fix Version/s: 5.0.0

Type: New Feature Priority: Medium
Reporter: Peter Puškár Assignee: Peter Puškár
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to NETCONF-1100 changed-leaf-nodes-only capability is... Resolved

 Description   

There is a need for an extension which has similar behavior to odl-leaf-nodes-only.
The nodes which have the same data written into them are not contained in the final notification. For that we perform additional check which is costing us CPU cycles hence we do not modify the original behavior rather we are making this new extension.

 Comments   
Comment by Robert Varga [ 19/Aug/22 ]

This change will change the semantics of the extension. Performing leaf-level comparison, which incurs significant CPU penalty vs. the current spec.
As such, I believe this needs to be done as a separate extension with the semantics specified.

Comment by Peter Puškár [ 22/Aug/22 ]

Okay, I can make this separate extension.

One more question though, the problem for this lies in the upstream implementation as the DataTreeCandidateNode that is passed down to serializeLeafNodesOnly is NormalizedNodeDataTreeCandidateNode (can it be other implementation?) which always returns ModificationType.WRITE in its getModificationType() implementation, even for the NormalizedNode which has same Before and After data.

Should the semantics in the upstream implementation stay as it is and we adjust to that as downstream user here? 

Generated at Wed Feb 07 20:16:06 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.