[NETCONF-884] Maven shade plugin replace netconf-testtol with scale-util inside release artifacts Created: 13/Jun/22 Updated: 25/Aug/22 Resolved: 12/Jul/22 |
|
| Status: | Resolved |
| Project: | netconf |
| Component/s: | netconf |
| Affects Version/s: | 2.0.16 |
| Fix Version/s: | 4.0.0, 3.0.6 |
| Type: | Bug | Priority: | Medium |
| Reporter: | Peter Suna | Assignee: | Peter Suna |
| Resolution: | Done | Votes: | 0 |
| Labels: | pt | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
Maven shade plugin introduces a feature, enabled by default: [0]. Odlparent picks it up in a regular version bump: [1]. Thus between a "good" merge run console output [2] and a "bad" one [3], the addition is that the bad one shows creation of dependency-reduced-pom.xml file (four times, once for each shaded jar, the scale-util [4] one remains just because it is built last), and maven-install-plugin then prefers taking that (instead of netconf/tools/netconf-testtool/pom.xml [5]) to be the pom the user wants to install as netconf-testtool-2.0.15-SNAPSHOT.pom [0] -> https://issues.apache.org/jira/browse/MSHADE-36 |
| Comments |
| Comment by Vratko Polak [ 13/Jun/22 ] |
|
The following describes a fix (in sense it restores previous behavior with no dependency-reduced-pom.xml created), it just needs to be placed in a correct place. |
| Comment by Robert Varga [ 13/Jun/22 ] |
|
odlparent does exactly nothing w.r.t. shade plugin configuration – hence this needs to be fixed in netconf. |
| Comment by Vratko Polak [ 14/Jun/22 ] |
|
I agree only netconf testtool seems to be affected by the artifact id consequence: But also other ODL projects should re-check their usage of maven-shade-plugin: |