[NETCONF-909] Fix odl-yanglib feature usage Created: 08/Nov/22  Updated: 21/Jun/23  Resolved: 14/Feb/23

Status: Resolved
Project: netconf
Component/s: netconf
Affects Version/s: 4.0.3
Fix Version/s: 3.0.9, 4.0.6, 5.0.2

Type: Bug Priority: Medium
Reporter: Peter Suna Assignee: Yaroslav Lastivka
Resolution: Done Votes: 0
Labels: pt
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: Text File karaf.log    
Issue Links:
Blocks
blocks NETCONF-772 Convert yanglib to OSGi DS Resolved
blocks NETCONF-910 Odl-yanglib fails to register provide... Resolved
blocks NETCONF-857 Export supported features to ietf-yan... Confirmed
Relates
relates to NETCONF-772 Convert yanglib to OSGi DS Resolved

 Description   

After converting YangLib project to blueprint feature,
https://git.opendaylight.org/gerrit/c/netconf/+/59530
Initialization stops working correctly and expect non-empty YanglibConfig provided by blueprint.
Blueprint creates empty YanglibConfig:
https://github.com/opendaylight/netconf/blob/master/netconf/yanglib/src/main/resources/OSGI-INF/blueprint/yanglib.xml#L13

After installing odl-yanglib feature:

feature:install odl-netconf-topology odl-restconf-nb odl-yanglib

Initialization will fail at line: https://github.com/opendaylight/netconf/blob/master/netconf/yanglib/src/main/java/org/opendaylight/yanglib/impl/YangLibProvider.java#L86

With message:

No cache-folder set in yanglib-config - yang library services will not be available

More in provided karaf logs.

After mentioned fix above for adding YangLib project to blueprint, is also not updated documentation for this feature. And is not clear how to use it.
https://docs.opendaylight.org/projects/netconf/en/latest/user-guide.html#yanglib-remote-repository

 Comments   
Comment by Ivan Hrasko [ 02/Jan/23 ]

The probable reason for incomplete activation is:

The OSGi Blueprint extension, as available via the odl-controller-blueprint feature is no longer transitively depended
on by odl-mdsal-broker. This change impacts downstreams who still use Blueprint as well as the OpenDaylight extensions,
like odl:type, odl:rpc-service and odl:clustered-app-config. Users who do not already explicitly pull in
odl-controller-blueprint will need to add this dependency to their feature.xml definitions, otherwise their Blueprint
containers will fail to activate – and thus fail SingleFeatureTest check

See ODL Sulfur docs.

Comment by Ivan Hrasko [ 02/Jan/23 ]

Try to fix the issue to be able to verify completeness of NETCONF-772.

Comment by Ivan Hrasko [ 11/Jan/23 ]

The most probable reason for the problem is missing default configuration.

Comment by Ivan Hrasko [ 14/Feb/23 ]

We have fixed the problem with default configuration and found out new problems: NETCONF-967 and NETCONF-968.

Generated at Wed Feb 07 20:16:13 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.