[NETCONF-911] JSON reader: Eliminate additional logic for augmented data Created: 10/Nov/22  Updated: 04/Jan/24

Status: Confirmed
Project: netconf
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Medium
Reporter: Ivan Hrasko Assignee: Ivan Hrasko
Resolution: Unresolved Votes: 0
Labels: pick-next, pt
Σ Remaining Estimate: Not Specified Remaining Estimate: Not Specified
Σ Time Spent: Not Specified Time Spent: Not Specified
Σ Original Estimate: Not Specified Original Estimate: Not Specified

Issue Links:
Blocks
is blocked by YANGTOOLS-1415 Deal with leading YangInstanceIdentif... In Progress
is blocked by YANGTOOLS-1468 JsonParserStream cannot read augmenta... Resolved
Issue split
split from NETCONF-747 Unable execute YANG patch request whe... Resolved
Sub-Tasks:
Key
Summary
Type
Status
Assignee
NETCONF-943 Create tests for different instances ... Sub-task Resolved Oleksandr Zharov  

 Description   

JsonNormalizedNodeBodyReader/JsonPatchBodyReader (as introduced in https://jira.opendaylight.org/browse/NETCONF-747) are using additional logic for Augmentation and Choice nodes.

while (result instanceof AugmentationNode || result instanceof ChoiceNode) { 

Interesting is that XmlNormalizedNodeBodyReader/XmlPatchBodyReader do not need this additional logic.

Create tests in Netconf/Yangtools to verify JsonParserStream/XmlParserStream behaviour and create bug report to Yangtools project if necessary.



 Comments   
Comment by Ivan Hrasko [ 16/Jan/23 ]

We have created tests to ensure YANG patch functionality with mixin nodes and bug in https://jira.opendaylight.org/browse/YANGTOOLS-1468.

Comment by Ivan Hrasko [ 04/Jan/24 ]

PATCH:

The issue has been resolved during Potassium MRI bump in https://git.opendaylight.org/gerrit/c/netconf/+/106533/19/restconf/restconf-nb/src/main/java/org/opendaylight/restconf/nb/rfc8040/jersey/providers/patch/JsonPatchBodyReader.java.

Comment by Ivan Hrasko [ 04/Jan/24 ]

For other than PATCH operation the issue is still present in JsonChildBody class.

Generated at Wed Feb 07 20:16:13 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.