[NETVIRT-1076] NeutronVpnManager: refactor associateNetworksToVpn: contains arrow anti-pattern Created: 01/Feb/18  Updated: 05/Apr/18  Resolved: 05/Apr/18

Status: Resolved
Project: netvirt
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Medium
Reporter: Valentina Krasnobaeva Assignee: Valentina Krasnobaeva
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

associateNetworksToVpn needs to be refactored to avoid arrow anti-pattern

https://git.opendaylight.org/gerrit/#/c/57411/153/vpnservice/neutronvpn/neutronvpn-impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronvpnManager.java@2241

Due to regression tests, it works:

https://logs.opendaylight.org/releng/vex-yul-odl-jenkins-1/netvirt-csit-1node-openstack-ocata-upstream-stateful-oxygen/822/log_full.html.gz#s1-s7

But it is worth to refactor this monster !

 

 

 

 

 

 

 

 

 

 

 

 Comments   
Comment by Valentina Krasnobaeva [ 26/Feb/18 ]

Rework was proposed in change:

https://git.opendaylight.org/gerrit/#/c/68203/

Generated at Wed Feb 07 20:23:10 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.