[NETVIRT-1385] Transaction leak in NatInterfaceStateChangeListener Created: 25/Jul/18  Updated: 31/Jul/18  Resolved: 31/Jul/18

Status: Resolved
Project: netvirt
Component/s: None
Affects Version/s: None
Fix Version/s: Oxygen-SR3, Fluorine

Type: Bug Priority: Highest
Reporter: Michael Vorburger Assignee: Stephen Kitt
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Blocks
blocks NETVIRT-1384 Umbrella: Numerous new transaction leaks Resolved

 Description   

NETVIRT-1384 attachements shows this suspected transaction leak in NatInterfaceStateChangeListener:

  DataBroker : newWriteOnlyTransaction()
    2602x transactions opened here, which are not closed:
      (...)
      org.opendaylight.controller.md.sal.binding.impl.BindingDOMDataBrokerAdapter.newWriteOnlyTransaction(BindingDOMDataBrokerAdapter.java:69)
      (...)
      org.opendaylight.netvirt.natservice.internal.NatInterfaceStateChangeListener$NatInterfaceStateUpdateWorker.call(NatInterfaceStateChangeListener.java:377)
      org.opendaylight.netvirt.natservice.internal.NatInterfaceStateChangeListener$NatInterfaceStateUpdateWorker.call(NatInterfaceStateChangeListener.java:356)
      org.opendaylight.infrautils.jobcoordinator.internal.JobCoordinatorImpl$MainTask.runWithUncheckedExceptionLogging(JobCoordinatorImpl.java:416)
      org.opendaylight.infrautils.utils.concurrent.LoggingUncaughtThreadDeathContextRunnable.run(LoggingUncaughtThreadDeathContextRunnable.java:60)
      java.util.concurrent.ForkJoinTask$RunnableExecuteAction.exec(ForkJoinTask.java:1402)
      java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289)
      java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056)
      java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692)
      java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157)


 Comments   
Comment by Michael Vorburger [ 25/Jul/18 ]

skitt do you already have this one? At first I thought it's dupe NETVIRT-1380 but c/74232 doesn't fix this?

Comment by Michael Vorburger [ 26/Jul/18 ]

skitt identified in IRC chat that we just have to back-port https://git.opendaylight.org/gerrit/#/c/71771/ to oxygen (master already OK).

Comment by Michael Vorburger [ 27/Jul/18 ]

which https://git.opendaylight.org/gerrit/#/c/74568/ is doing

Generated at Wed Feb 07 20:23:56 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.