[#NETVIRT-193] Learn SG - ICMP matches should be more specific - using OFPXMT_OFB_ICMPV4_TYPE and OFPXMT_OFB_ICMPV4

[NETVIRT-193] Learn SG - ICMP matches should be more specific - using OFPXMT_OFB_ICMPV4_TYPE and OFPXMT_OFB_ICMPV4_CODE Created: 06/Oct/16 Updated: 19/Oct/17 Resolved: 06/Oct/16
Status:	Resolved
Project:	netvirt
Component/s:	General
Affects Version/s:	Boron
Fix Version/s:	None

Type:

Bug

Reporter:

Alon Kochba

Assignee:

Unassigned

Resolution:

Cannot Reproduce

Votes:

Labels:

None

Remaining Estimate:

Not Specified

Time Spent:

Not Specified

Original Estimate:

Not Specified

Environment:

Operating System: All
Platform: All

External issue ID:

6872

Description

currently learn SG are implemented by only matching IP fields - however we can and should use the ICMP TYPE and CODE to best match the ICMP reverse flow, like we do in UDP/TCP

Comments

Comment by Alon Kochba [ 06/Oct/16 ]

Confused type/code with identifier/seq number which are not matchable.
Also seems like ICMP has more nuances - the identifier/seq number are optional, and the type/code aren't necessarily the same between the request/response.

Generated at Wed Feb 07 20:20:56 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.

[NETVIRT-193] Learn SG - ICMP matches should be more specific - using OFPXMT_OFB_ICMPV4_TYPE and OFPXMT_OFB_ICMPV4_CODE Created: 06/Oct/16 Updated: 19/Oct/17 Resolved: 06/Oct/16