[NETVIRT-270] gw mac can't resolve - exception thrown in ArpNotificationHandler Created: 14/Nov/16  Updated: 16/Nov/16  Resolved: 16/Nov/16

Status: Resolved
Project: netvirt
Component/s: General
Affects Version/s: Boron
Fix Version/s: None

Type: Bug
Reporter: Koby Aizer Assignee: Vivekanandan Narasimhan
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All


External issue ID: 7168

 Description   

It seems this commit [1] caused regression for the external gateway use case again..
In ArpNotificationHandler you now check if the traffic is arriving from a neutron port (isNeutronPortConfigured).
However this causes an exception when using non-neutron interfaces, and the ARP isn't learned.

2016-11-13 12:29:00,303 | ERROR | pool-24-thread-1 | DOMNotificationRouterEvent | 167 - org.opendaylight.controller.sal-broker-impl - 1.5.0.SNAPSHOT | Delivery of notification org.opendaylight.controller.md.sal.binding.impl.LazySerializedDOMNotification@5fb4384a caused an error in listener org.opendaylight.controller.md.sal.binding.impl.BindingDOMNotificationListenerAdapter@68152c28
java.lang.IllegalArgumentException: Supplied value "154710820308539:eth1:flat" does not match required pattern "^[0-9a-fA-F]

{8}

-[0-9a-fA-F]

{4}-[0-9a-fA-F]{4}

-[0-9a-fA-F]

{4}

-[0-9a-fA-F]

{12}

$"
at com.google.common.base.Preconditions.checkArgument(Preconditions.java:145)[65:com.google.guava:18.0.0]
at org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.yang.types.rev130715.Uuid.<init>(Uuid.java:55)[109:org.opendaylight.mdsal.model.ietf-yang-types-20130715:2013.7.15.10-SNAPSHOT]
at org.opendaylight.netvirt.vpnmanager.VpnUtil.isNeutronPortConfigured(VpnUtil.java:1201)[369:org.opendaylight.netvirt.vpnmanager-impl:0.4.0.SNAPSHOT]
at org.opendaylight.netvirt.vpnmanager.ArpNotificationHandler.onArpRequestReceived(ArpNotificationHandler.java:143)[369:org.opendaylight.netvirt.vpnmanager-impl:0.4.0.SNAPSHOT]
at org.opendaylight.yangtools.yang.binding.util.NotificationListenerInvoker.invokeNotification(NotificationListenerInvoker.java:91)[73:org.opendaylight.mdsal.yang-binding:0.10.0.SNAPSHOT]



 Comments   
Comment by Vivekanandan Narasimhan [ 15/Nov/16 ]

The review that fixes this is here:

https://git.opendaylight.org/gerrit/#/c/48346/

Comment by Vivekanandan Narasimhan [ 15/Nov/16 ]

This fix should go into SR2 of Stable/Boron.

Generated at Wed Feb 07 20:21:08 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.