[NETVIRT-28] Wrong logging in NetvirtSfcStandaloneOF13Provider Created: 13/Jun/16  Updated: 09/Mar/18  Resolved: 26/Jul/16

Status: Resolved
Project: netvirt
Component/s: None
Affects Version/s: Beryllium
Fix Version/s: None

Type: Bug
Reporter: Javier Arauz Assignee: Dileep Ranganathan
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All

External issue ID: 6056

 Description   

In class org.opendaylight.netvirt.openstack.netvirt.sfc.standalone.openflow13.NetvirtSfcStandaloneOF13Provider, method processAclEntry(), logging is wrong. From line 185:

185 long localOfPort = southbound.getOFPort(bridgeNode, CLIENT_PORT_NAME);
186 if (localOfPort == 0L) {
187 LOG.error("programAclEntry: Could not identify local port {} -> OF ({}) on {}",
188 CLIENT_GPE_PORT_NAME, localOfPort, bridgeNode);
189 return;
190 }

Obviously, line 188 should be instead:

188 CLIENT_PORT_NAME, localOfPort, bridgeNode);

 Comments   
Comment by Javier Arauz [ 13/Jun/16 ]

A little bit further down in the same file, starting at line 225:

225 long tunnelOfPort = southbound.getOFPort(bridgeNode, SERVER_GPE_PORT_NAME);
226 if (tunnelOfPort == 0L) {
227 LOG.error("programAclEntry: Could not identify tunnel port {} -> OF ({}) on {}",
228 CLIENT_GPE_PORT_NAME, tunnelOfPort, bridgeNode);
229 return;
230 }
231
232 long localOfPort = southbound.getOFPort(bridgeNode, SERVER_PORT_NAME);
233 if (localOfPort == 0L) {
234 LOG.error("programAclEntry: Could not identify local port {} -> OF ({}) on {}",
235 CLIENT_GPE_PORT_NAME, localOfPort, bridgeNode);
236 return;
237 }

Obviously, lines 228 and 235 should be instead, respectively:

228 SERVER_GPE_PORT_NAME, tunnelOfPort, bridgeNode);

235 SERVER_PORT_NAME, localOfPort, bridgeNode);

Comment by Sam Hague [ 15/Jun/16 ]

b: https://git.opendaylight.org/gerrit/40257
be: https://git.opendaylight.org/gerrit/40345

Generated at Wed Feb 07 20:20:31 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.