Operating System: All
Platform: All

This issue has the potential to cause upstream CSIT failures.

So bumping this bug to critical.

Fixes NPE in programConntrackRecircRules and syncSpecificAclFlow in AclService

https://git.opendaylight.org/gerrit/#/c/59900/

Below commit fixes NPE observed in bindAcl() of AclService:
https://git.opendaylight.org/gerrit/#/c/59916/

https://git.opendaylight.org/gerrit/59887

A patch was submitted to fix this bug in Carbon SR1: https://git.opendaylight.org/gerrit/#/c/59887/
https://git.opendaylight.org/gerrit/#/c/59900
https://git.opendaylight.org/gerrit/#/c/59910

To better assess the impact of this bug and fix, could someone from your team please help us identify the following:
Regression: Is this bug a regression of functionality/performance/feature compared to Carbon?
Severity: Could you elaborate on the severity of this bug? Is this a BLOCKER such that we cannot release Carbon SR1 without it?
Workaround: Is there a workaround such that we can write a release note instead?
Testing: Could you also elaborate on the testing of this patch? How extensively has this patch been tested? Is it covered by any unit tests or system tests?
Impact: Does this fix impact any dependent projects?

(In reply to A H from comment #5)
> Regression: Is this bug a regression of functionality/performance/feature
> compared to Carbon?

Not sure, it’s probably also present in Carbon.

> Severity: Could you elaborate on the severity of this bug? Is this a
> BLOCKER such that we cannot release Carbon SR1 without it?

From our point of view yes, these errors cause severe mis-behaviours in NetVirt, rendering the controller useless in setups where NetVirt is used and the conditions arise causing these NPEs. Given their frequency in CSIT, that’s likely to happen in production setups too.

> Workaround: Is there a workaround such that we can write a release note
> instead?

No.

> Testing: Could you also elaborate on the testing of this patch? How
> extensively has this patch been tested? Is it covered by any unit tests or
> system tests?

It’s covered by CSIT.

> Impact: Does this fix impact any dependent projects?

No.

Please help elaborate on the regression. After the cutoff, the release team only permits blocker bugs with true regression in functionality from a previous release. My understanding from reading the bug description is that the NPE did not appear before, but have started appearing in Carbon SR1. This suggests to me that there exists some demonstrable regression.

(In reply to Stephen Kitt from comment #6)
> (In reply to A H from comment #5)
> > Regression: Is this bug a regression of functionality/performance/feature
> > compared to Carbon?
>
> Not sure, it’s probably also present in Carbon.
>
> > Severity: Could you elaborate on the severity of this bug? Is this a
> > BLOCKER such that we cannot release Carbon SR1 without it?
>
> From our point of view yes, these errors cause severe mis-behaviours in
> NetVirt, rendering the controller useless in setups where NetVirt is used
> and the conditions arise causing these NPEs. Given their frequency in CSIT,
> that’s likely to happen in production setups too.
>
> > Workaround: Is there a workaround such that we can write a release note
> > instead?
>
> No.
>
> > Testing: Could you also elaborate on the testing of this patch? How
> > extensively has this patch been tested? Is it covered by any unit tests or
> > system tests?
>
> It’s covered by CSIT.
>
> > Impact: Does this fix impact any dependent projects?
>
> No.

Has this blocker bug been verified as fixed in Carbon SR1 Build 20170711?