[NETVIRT-926] setmaxpath value range should be between 1 to 64 in BGP multipath Created: 21/Sep/17  Updated: 02/Nov/17  Resolved: 28/Sep/17

Status: Verified
Project: netvirt
Component/s: General
Affects Version/s: Carbon
Fix Version/s: None

Type: Bug
Reporter: jitendra kumar Assignee: Jitendra Kumar
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All

External issue ID: 9196
Priority: Normal

 Description   

observation-
opendaylight-user@root>odl:multipath -f lu enable
opendaylight-user@root>multipath -r 1:1 -f lu -n 0 setmaxpath >>> this should throw error
opendaylight-user@root>bgp-cache

Configuration Server
Host 192.168.122.201
Port 7644

BGP Router
AS-Number 200
Router-ID 20.20.20.20
Stale-Path-Time default
F-bit ON
Log-File /var/log/bgp_debug.log
Log-Level errors

Multipath
Address-Families vpnv4

RD Maxpath
1:1 0 >>>>>>>>>>>>>>>>>> Allowed to configure which is not correct

opendaylight-user@root>odl:multipath -f lu enable
opendaylight-user@root>multipath -r 1:1 -f lu -n 65 setmaxpath >>>>>> setmaxpath configured as 65, which should not allowed
opendaylight-user@root>
opendaylight-user@root>bgp-cache

Configuration Server
Host 192.168.122.201
Port 7644

BGP Router
AS-Number 200
Router-ID 20.20.20.20
Stale-Path-Time default
F-bit ON
Log-File /var/log/bgp_debug.log
Log-Level errors

Multipath
Address-Families vpnv4

RD Maxpath
1:1 65 >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>

opendaylight-user@root>multipath -r 1:1 -f lu -n 100 setmaxpath >>>>>> setmaxpath configured as 100, which should not allowed
opendaylight-user@root>bgp-cache

Configuration Server
Host 192.168.122.201
Port 7644

BGP Router
AS-Number 200
Router-ID 20.20.20.20
Stale-Path-Time default
F-bit ON
Log-File /var/log/bgp_debug.log
Log-Level errors

Multipath
Address-Families vpnv4

RD Maxpath
1:1 100

 Comments   
Comment by Gowri R [ 28/Sep/17 ]

Added a check to ensure the maxpath value is between 1 and 64
Gerrit reviews:
https://git.opendaylight.org/gerrit/#/c/63434/
https://git.opendaylight.org/gerrit/#/c/63400/
https://git.opendaylight.org/gerrit/#/c/63433/

Comment by Gowri R [ 31/Oct/17 ]

Fix checked in - https://git.opendaylight.org/gerrit/#/c/64648

Comment by Jitendra Kumar [ 02/Nov/17 ]

I have verified this with distribution: distribution-karaf-0.6.3-20171102.041639-88.zip
and it worked fine-
opendaylight-user@root>vpn-show
No Config VpnInterface is present
No Oper VpnInterface is present
-----------------------------------------------------------------------
VpnInstanceName RD Config Count Oper Count

-----------------------------------------------------------------------
12345678-1234-1234-1234-123456789300 [1:1] 0 0
-----------------------------------------------------------------------
Total Count: 0 0

Usage:To display vpn-interfaces for a particular vpnInstance vpn-show --detail [<vpnInstanceName>]
opendaylight-user@root>
opendaylight-user@root>multipath -r 1:1 -f lu -n 0 setmaxpath
error: --maxpath range[1 - 64]
opendaylight-user@root>multipath -r 1:1 -f lu -n 64 setmaxpath
opendaylight-user@root>multipath -r 1:1 -f lu -n 65 setmaxpath
error: --maxpath range[1 - 64]
opendaylight-user@root>

Generated at Wed Feb 07 20:22:49 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.