[NEUTRON-138] Major Bug in Neutron ( Module integration-test) Created: 24/Sep/16  Updated: 19/Oct/16  Resolved: 19/Oct/16

Status: Resolved
Project: neutron
Component/s: General
Affects Version/s: master
Fix Version/s: None

Type: Bug
Reporter: Pramod Raghavendra Jayathirth Assignee: Pramod Raghavendra Jayathirth
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: Linux
Platform: Other
URL: https://jenkins.opendaylight.org/releng/job/neutron-verify-carbon-mvn33-openjdk8/62/findbugsResult/HIGH/module.34108651/


External issue ID: 6796
Priority: High

 Description   

https://jenkins.opendaylight.org/releng/job/neutron-verify-carbon-mvn33-openjdk8/62/findbugsResult/HIGH/module.34108651/

The bugs are identified and resolved by using the FindBugs Plugin.



 Comments   
Comment by Pramod Raghavendra Jayathirth [ 27/Sep/16 ]

The bugs to be resolved are from Module integration-test. Their Description are as follows.

Note :- 3 out of 6 High priority bugs are resolved in this item.

1. NeutronL2gatewayConnectionNorthbound.java:118, EC_UNRELATED_TYPES, Priority: High
Call to String.equals(Integer) in org.opendaylight.neutron.northbound.api.NeutronL2gatewayConnectionNorthbound.listL2gatewayConnections(List, String, String, String, String, String, String, String, String, String)

This method calls equals(Object) on two references of different class types and analysis suggests they will be to objects of different classes at runtime. Further, examination of the equals methods that would be invoked suggest that either this call will always return false, or else the equals method is not be symmetric (which is a property required by the contract for equals in class Object).

2. NeutronL2gatewayNorthbound.java:116, EC_UNRELATED_CLASS_AND_INTERFACE, Priority: High
Call to String.equals(java.util.List) in org.opendaylight.neutron.northbound.api.NeutronL2gatewayNorthbound.listL2gateways(List, String, String, String, String, String, String, String)

This method calls equals(Object) on two references, one of which is a class and the other an interface, where neither the class nor any of its non-abstract subclasses implement the interface. Therefore, the objects being compared are unlikely to be members of the same class at runtime (unless some application classes were not analyzed, or dynamic class loading can occur at runtime). According to the contract of equals(), objects of different classes should always compare as unequal; therefore, according to the contract defined by java.lang.Object.equals(Object), the result of this comparison will always be false at runtime.

3. NeutronRoutersNorthbound.java:102, EC_UNRELATED_TYPES, Priority: High
Call to String.equals(org.opendaylight.neutron.spi.NeutronRouter_NetworkReference) in org.opendaylight.neutron.northbound.api.NeutronRoutersNorthbound.listRouters(List, String, String, Boolean, String, String, String, String, String, String)

This method calls equals(Object) on two references of different class types and analysis suggests they will be to objects of different classes at runtime. Further, examination of the equals methods that would be invoked suggest that either this call will always return false, or else the equals method is not be symmetric (which is a property required by the contract for equals in class Object).

Generated at Wed Feb 07 20:25:39 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.