[NEUTRON-74] protocol field in security group rule is lower case of imcp, icmpv6, tcp and udp Created: 30/Sep/15  Updated: 01/Jun/16  Resolved: 01/Jun/16

Status: Resolved
Project: neutron
Component/s: transcriber
Affects Version/s: unspecified
Fix Version/s: None

Type: Bug
Reporter: Isaku Yamahata Assignee: Abbas P Pareedkunju
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All

External issue ID: 4383

 Description   

protocol field in security group rule is lower case of imcp, icmpv6, tcp and udp
This is defined in neutron/extension/securitygroup.py

The following is the packet capture.
POST /controller/nb/v2/neutron/security-group-rules HTTP/1.1
Host: 143.183.96.62:8087
Content-Length: 397
Accept-Encoding: gzip, deflate
Accept: /
User-Agent: python-requests/2.7.0 CPython/2.7.6 Linux/3.13.0-63-generic
Connection: keep-alive
Content-Type: application/json
Authorization: Basic YWRtaW46YWRtaW4=

{
"security_group_rule":

{ "remote_group_id": null, "direction": "ingress", "remote_ip_prefix": null, "protocol": "tcp", "ethertype": "IPv4", "tenant_id": "6f25fa70b0e547d8aab2f68ea4c138fd", "port_range_max": 81, "port_range_min": 80, "id": "1fbe4810-e2a6-4d8a-ab0d-553dc5345a44", "security_group_id": "919bb6ed-2929-4d6e-b269-b321d59fe499" }

}

 Comments   
Comment by Isaku Yamahata [ 30/Sep/15 ]

https://git.opendaylight.org/gerrit/#/c/27675/

Comment by Abbas P Pareedkunju [ 31/May/16 ]

Hi Isaku,

I could see the patch you have submitted has been abandoned. But the latest code as on today has the fix available.

private static final ImmutableBiMap<Class<? extends ProtocolBase>,String> PROTOCOL_MAP
= new ImmutableBiMap.Builder<Class<? extends ProtocolBase>,String>()
.put(ProtocolIcmp.class,"icmp")
.put(ProtocolTcp.class,"tcp")
.put(ProtocolUdp.class,"udp")
.put(ProtocolIcmpV6.class,"icmpv6")
.build();

Can I close this bug in this case?

Thanks,
Abbas

Comment by Isaku Yamahata [ 01/Jun/16 ]

https://git.opendaylight.org/gerrit/#/c/27674/

Generated at Wed Feb 07 20:25:29 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.