[OCPPLUGIN-2] OCP resource model yang file needs cleanup Created: 25/Apr/16 Updated: 24/May/16 Resolved: 24/May/16 |
|
| Status: | Resolved |
| Project: | ocpplugin |
| Component/s: | General |
| Affects Version/s: | unspecified |
| Fix Version/s: | None |
| Type: | Bug | ||
| Reporter: | Chin-Hung Chien | Assignee: | Dhevendran Kulandaivel |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
Operating System: All |
||
| External issue ID: | 5792 |
| Priority: | Normal |
| Description |
|
ocpplugin/applications/ocp-service/src/main/yang/ocp-resourcemodel.yang, which is the yang file describing the supported OCP resource model objects, contains a large number of "// config false;" comments which should be removed for better readability. Besides, it'd be better to change the description of the yang file from "OCP service resourcemodel" to "OCP Resource Model" for clarity. And please note that, in other yang files, the two fields "organization" and "contact" have been removed to avoid showing vendor trademarks, logos, product names, etc; this yang file should be modified accordingly. |
| Comments |
| Comment by Dhevendran Kulandaivel [ 23/May/16 ] |
|
Hi Chin-Hung Chien I have clean up this yang file as per the suggestion. The fix is available in this check-in : https://git.opendaylight.org/gerrit/#/c/39232/ Thanks & Regards, |
| Comment by Chin-Hung Chien [ 23/May/16 ] |
|
(In reply to Dhevendran Kulandaivel from comment #1) Hi Dhevendran, Thanks for the fix. Please take a look at my review comments at gerrit and then update your patch. BTW, I noticed that jenkins verify failed due to infrastructure issues. Regards, |
| Comment by Dhevendran Kulandaivel [ 24/May/16 ] |
|
The FIX is available now |