[ODLPARENT-111] Medium security issue in commons-beanutils on Nexus IQ server CLM Job Created: 15/Aug/17  Updated: 07/Mar/19  Resolved: 07/Mar/19

Status: Resolved
Project: odlparent
Component/s: General
Affects Version/s: 2.0.5
Fix Version/s: 3.1.6, 4.0.9

Type: Bug
Reporter: Michael Vorburger Assignee: Unassigned
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All


External issue ID: 8993

 Description   

An Ho on https://lists.opendaylight.org/pipermail/release/2017-August/011985.html raises a number of issues on Nexus IQ server CLM Job seen e.g. here: https://clm.opendaylight.org/assets/index.html#/reports/daexim/d3d1cd100d6a4443a997ad713f474c35, among them something re. a Security-Medium issue in commons-beanutils 1.8.3.

Let's see if we can bump all usages of commons-beanutils 1.8.3 to the latest 1.9.3 ...



 Comments   
Comment by Michael Vorburger [ 15/Aug/17 ]

According to a quick scan of autorelease, beanutils is used by aaa, vtn, tsdr, and odlparent itself.

We do have a system/commons-beanutils/commons-beanutils/1.8.3/commons-beanutils-1.8.3.jar in odlparent's karaf empty, and some distributions.

As far as I can see from a first quick grep in odlparent, this (commons-beanutils) does not appear in our <dependencyManagement>, where it should be if any projects uses this as a regular <dependency>. Raised https://git.opendaylight.org/gerrit/#/c/61752/ to add it, and https://git.opendaylight.org/gerrit/#/c/61753/ for aaa.

It does however also appear in the karaf-paxweb.patch pax-web-features-4.3.0-features.xml ... have attempted to change that, but failed - maybe just a mistake in the patch, or something bigger... I'll let someone else pick that up? Or that will just get sorted out with the next Karaf upgrade, if they keep bumping their dep to pax-web, if they keep bumping 3rd party deps to commons.

vtn and tsdr I don't care about, and won't have the spare cycles to deal with. They should do sth similar like c/61753.

Comment by Michael Vorburger [ 15/Aug/17 ]

> also appear in the karaf-paxweb.patch pax-web-features-4.3.0-features.xml

which https://git.opendaylight.org/gerrit/#/c/61760/ fixes - except that it completely irrelevant for us here - it only fixes up paxweb's pax-jsf-support feature, which we do not use.

Comment by Stephen Kitt [ 16/Aug/17 ]

(In reply to Michael Vorburger from comment #1)
> According to a quick scan of autorelease, beanutils is used by aaa, vtn,
> tsdr, and odlparent itself.

Very quick scan . beanutils ends up being referred to in order to fix various issues with transitive dependencies, there are no code dependencies on it. Ideally I wouldn’t want projects relying on beanutils, so I don’t want to have it in dependency management.

Comment by Stephen Kitt [ 16/Aug/17 ]

I humbly suggest https://git.opendaylight.org/gerrit/61844 instead (on AAA only).

Comment by Michael Vorburger [ 16/Aug/17 ]

> I humbly suggest https://git.opendaylight.org/gerrit/61844 instead (on AAA only).

I don't want to stand in the way of doing it like this, so don't mind abandoning my proposed changes to odlparent and aaa re. this - BUT these only accept aaa, and not the other projects using commons-beanutils... which is fine for me and those who pay the roof over my head but I wanted to spell it out here, so someone interested in other projects could follow-up with those, if needed.

Comment by Stephen Kitt [ 16/Aug/17 ]

(In reply to Michael Vorburger from comment #5)
> > I humbly suggest https://git.opendaylight.org/gerrit/61844 instead (on AAA only).
>
> I don't want to stand in the way of doing it like this, so don't mind
> abandoning my proposed changes to odlparent and aaa re. this - BUT these
> only accept aaa, and not the other projects using commons-beanutils... which
> is fine for me and those who pay the roof over my head but I wanted to
> spell it out here, so someone interested in other projects could follow-up
> with those, if needed.

No other project directly uses beanutils.

Comment by Michael Vorburger [ 16/Aug/17 ]

> No other project directly uses beanutils.

OK, perfect!

>> According to a quick scan of autorelease, beanutils is used by aaa, vtn,
>> tsdr, and odlparent itself.

> Very quick scan . beanutils ends up being referred to in order to fix various issues with transitive dependencies, there are no code dependencies on it.

Yup; indeed the hit I saw in vtn on grep is not a dependency, tsdr's features/odl-tsdr-hbase/src/main/feature/feature.xml used a mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.commons-beanutils/1.8.3_1 - but tsdr is no longer in the release - so forget about it)

Generated at Wed Feb 07 20:27:39 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.