[ODLPARENT-128] Enforcer rules collide with guava-testlib Created: 18/Oct/17  Updated: 05/Sep/18  Resolved: 05/Sep/18

Status: Resolved
Project: odlparent
Component/s: General
Affects Version/s: 3.0.2
Fix Version/s: None

Type: Bug
Reporter: Robert Varga Assignee: Michael Vorburger
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All


External issue ID: 9312

 Description   

[INFO] — maven-enforcer-plugin:1.4.1:enforce (enforce-banned-dependencies) @ util —
[WARNING] Rule 0: org.apache.maven.plugins.enforcer.BannedDependencies failed with message:
Please always use mockito-core instead of mockito-all, and findbugs:annotations instead of findbugs:jsr305 (see https://bugs.opendaylight.org/show_bug.cgi?id=7662 & https://bugs.opendaylight.org/show_bug.cgi?id=7663)
Found Banned Dependency: com.google.code.findbugs:jsr305:jar:1.3.9
Use 'mvn dependency:tree' to locate the source of the banned dependencies.

which boils down to:

nite@nitebug : ~/odl/yangtools/common/util on * $ mvn dependency:tree
[INFO] Scanning for projects...
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Building util 2.0.0-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO]
[INFO] — maven-dependency-plugin:3.0.2:tree (default-cli) @ util —
[INFO] org.opendaylight.yangtools:util:bundle:2.0.0-SNAPSHOT
[INFO] +- org.opendaylight.yangtools:concepts:jar:2.0.0-SNAPSHOT:compile
[INFO] +- org.opendaylight.yangtools:triemap:jar:1.0.0-SNAPSHOT:compile
[INFO] +- com.google.guava:guava:jar:23.0:compile
[INFO] | +- com.google.errorprone:error_prone_annotations:jar:2.0.18:compile
[INFO] | +- com.google.j2objc:j2objc-annotations:jar:1.1:compile
[INFO] | - org.codehaus.mojo:animal-sniffer-annotations:jar:1.14:compile
[INFO] +- junit:junit:jar:4.11:test
[INFO] | - org.hamcrest:hamcrest-core:jar:1.3:test
[INFO] +- org.opendaylight.yangtools:mockito-configuration:jar:2.0.0-SNAPSHOT:test
[INFO] | - org.mockito:mockito-core:jar:1.10.19:test
[INFO] | - org.objenesis:objenesis:jar:2.1:test
[INFO] +- com.google.guava:guava-testlib:jar:23.0:test
[INFO] | - com.google.code.findbugs:jsr305:jar:1.3.9:test
[INFO] +- org.slf4j:slf4j-api:jar:1.7.21:provided
[INFO] +- org.slf4j:slf4j-simple:jar:1.7.21:test
[INFO] +- com.google.code.findbugs:annotations:jar:3.0.0:provided
[INFO] - org.eclipse.jdt:org.eclipse.jdt.annotation:jar:2.1.0:provided



 Comments   
Comment by Michael Vorburger [ 03/Nov/17 ]

The easiest and trivial fix is proably if we just exclude com.google.code.findbugs:jsr305 on the com.google.guava:guava-testlib dependency, no?

https://git.opendaylight.org/gerrit/#/c/64443/ by skitt did exactly that, and fixed this AFAIK.

rovarga please re-open issue and feel free to assign with more details if you disagree...

Generated at Wed Feb 07 20:27:42 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.