[ODLPARENT-137] Karaf prompt does not start with opendaylight-user@ anymore Created: 17/Jan/18  Updated: 05/Sep/18  Resolved: 05/Sep/18

Status: Resolved
Project: odlparent
Component/s: Karaf
Affects Version/s: 3.0.2, 3.1.0, 3.0.3
Fix Version/s: 3.1.1

Type: Bug Priority: High
Reporter: Michael Vorburger Assignee: Stephen Kitt
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

In https://lists.opendaylight.org/pipermail/dev/2018-January/004449.html k.faseela and thapar raise that, following the odlparent bump from 2.0.6 to 3.0.2, the prompt in Karaf changed:

FYI, another thing it has changed impacting the CSIT is the karaf console prompt:

  • It used to be: opendaylight-user at root>
  • And now it is: karaf at root()>

Because of this, some of the CSIT doing operations in karaf console are taking very long.

Is there a way to come back to old format or should we change the tests for the new prompt?

and:

+1 to retaining older prompt, as I see genius CSIT failing with newer prompt on the genius only distribution which we are trying to verify locally.

 Comments   
Comment by Michael Vorburger [ 17/Jan/18 ]

I've looked into this, and found that this opendaylight-user prompt is from our custom ODL Karaf branding, in odlparent/karaf/karaf-branding/src/main/resources/org/apache/karaf/branding/branding.properties (which FTR ends up in JAR, not in etc/branding.properties; that's why grep didn't immediately find it), whereas karaf@root()> is simply the upstream default.

That branding stuff hasn't changed in odlparent, and notably that ASCII art ODL logo thing still works... so digging further, I've found that the prompt customization branding support somehow broke upstream - so this is an impact of our Karaf bump. Let's see what they say over on https://issues.apache.org/jira/browse/KARAF-5570 .. but even if fixed (by a contribution from me or anyone), the fix will most likely require going through a new Karaf release and bump in odlparent and odlparent release and all projects bumping to new odlparent...

So in the short term, changing CSIT tests for the new prompt is the way to go IMHO.

Comment by Faseela K [ 17/Jan/18 ]

 Not sure whether this is a centralized one line change for whole of integration/test though

Comment by Jamo Luhrsen [ 17/Jan/18 ]

vorburger it would be just a one/few lines change if the prompt was changing across all versions of ODL, but we'd have to account
for the fact that only oxygen+ would have this new prompt, while carbon and nitrogen will still use the old prompt. Not sure how easy it will
be to change at this point. Seems like it might be our only option though.

Comment by Stephen Kitt [ 19/Jan/18 ]

 This is fixed by https://git.opendaylight.org/gerrit/67340 in integration/distribution.

Comment by Stephen Kitt [ 19/Jan/18 ]

I’ll add a fix in odlparent too (hence not moving this bug and not resolving it yet).

Comment by Stephen Kitt [ 03/Apr/18 ]

At long last, the odlparent patch is ready: https://git.opendaylight.org/gerrit/70285

Comment by Michael Vorburger [ 04/Apr/18 ]

skitt perhaps it would be useful to set the Fix Version on this appropriately - Flourine and Oxygen SP1, is it?

Generated at Wed Feb 07 20:27:44 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.