[ODLPARENT-146] The FindBugs upgrade introduces a breaking regression wrt. non-null parameters Created: 28/Mar/18  Updated: 24/Apr/18  Resolved: 24/Apr/18

Status: Resolved
Project: odlparent
Component/s: None
Affects Version/s: None
Fix Version/s: 3.1.2, 4.0.0

Type: Bug Priority: Medium
Reporter: Stephen Kitt Assignee: Stephen Kitt
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

E.g.

 

[INFO] — findbugs-maven-plugin:3.0.5:check (analyze-compile) @ sal-inmemory-datastore —
[INFO] BugInstance size is 1
[INFO] Error size is 0
[INFO] Total bugs: 1
[INFO] Null passed for non-null parameter of com.google.common.util.concurrent.Futures.immediateFuture(Object) in org.opendaylight.controller.md.sal.dom.store.impl.InMemoryDOMStoreThreePhaseCommitCohort.<static initializer for InMemoryDOMStoreThreePhaseCommitCohort>() [org.opendaylight.controller.md.sal.dom.store.impl.InMemoryDOMStoreThreePhaseCommitCohort] At InMemoryDOMStoreThreePhaseCommitCohort.java:[line 30] NP_NONNULL_PARAM_VIOLATION

 Comments   
Comment by Stephen Kitt [ 29/Mar/18 ]

https://git.opendaylight.org/gerrit/70173 fixes this by disabling NP_NONNULL_PARAM_VIOLATION in our FindBugs setup.

Comment by Stephen Kitt [ 17/Apr/18 ]

This also needs to exclude the following: RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE, NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE, NP_NULL_PARAM_DEREF.

Comment by Stephen Kitt [ 24/Apr/18 ]

Fixed by https://git.opendaylight.org/gerrit/71040

Generated at Wed Feb 07 20:27:45 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.