[ODLPARENT-264] Fix thread safety around depends-maven-plugin Created: 29/Sep/21 Updated: 26/Dec/23 |
|
| Status: | Confirmed |
| Project: | odlparent |
| Component/s: | SFT |
| Affects Version/s: | None |
| Fix Version/s: | 14.0.0, 13.0.11 |
| Type: | Improvement | Priority: | Medium |
| Reporter: | Robert Varga | Assignee: | Unassigned |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | pt | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Epic Link: | Faster Builds | ||||||||||||||||
| Description |
|
We are getting this splat during parallel -Pq build: [INFO] -----------< org.opendaylight.odlparent:features-odlparent >------------ [INFO] Building ODL :: odlparent :: features-odlparent 9.0.7-SNAPSHOT [61/63] [INFO] ------------------------------[ feature ]------------------------------- [WARNING] ***************************************************************** [WARNING] * Your build is requesting parallel execution, but project * [WARNING] * contains the following plugin(s) that have goals not marked * [WARNING] * as @threadSafe to support parallel building. * [WARNING] * While this /may/ work fine, please look for plugin updates * [WARNING] * and/or request plugins be made thread-safe. * [WARNING] * If reporting an issue, report it against the plugin in * [WARNING] * question, not against maven-core * [WARNING] ***************************************************************** [WARNING] The following plugins are not marked @threadSafe in ODL :: odlparent :: features-odlparent: [WARNING] org.apache.servicemix.tooling:depends-maven-plugin:1.4.0 [WARNING] Enable debug to see more precisely which goals are not marked @threadSafe. [WARNING] ***************************************************************** Unfortunately https://github.com/apache/servicemix-maven-plugins seems to be quite dead, so we may need to rework the integration completely. |
| Comments |
| Comment by Robert Varga [ 29/Sep/21 ] |
|
So this affects only SFT, hence may end up being a duplicate of ODLPARENT-262. |
| Comment by Robert Varga [ 29/Sep/21 ] |
|
It seems all usage of the plugin has to do with launching pax-exam from surefire. Perhaps we should provide a better alternative? |
| Comment by Ruslan Kashapov [ 16/Aug/23 ] |
|
depends-maven-plugin is only used to determine current version of the SCR feature being preset for SFT. // Install SCR features(maven().groupId("org.apache.karaf.features").artifactId("standard").type("xml") .classifier("features").versionAsInProject(), "scr"), the versionAsInProject() is a pax-exam logic which relies on data from file in order to rid of dependency on this plugin we just need to provide the version directly this is being proposed as apart of solution for in further perspectives (if SFT is implemented as maven plugin) then dependencies can be handled internally |
| Comment by Robert Varga [ 10/Sep/23 ] |
|
SFT spawns karaf instances, which may access network ports and similar, hence ODLPARENT-262 will introduce better wiring with maven, e.g. we can resolve these dependencies. That will render depends-maven-plugin obsolete. |