[ODLPARENT-36] Reduce the usage of org.json Created: 02/Jun/16  Updated: 07/Mar/19  Resolved: 07/Mar/19

Status: Resolved
Project: odlparent
Component/s: General
Affects Version/s: None
Fix Version/s: 5.0.0

Type: Bug
Reporter: Stephen Kitt Assignee: Robert Varga
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All

Issue Links:
Blocks
is blocked by NETCONF-213 Replace use of org.json library with ... Resolved
is blocked by AAA-173 Removal of AAA Oauth2/Token Identity ... Resolved
is blocked by NETCONF-471 ListenerAdapter needs to serialize JS... Resolved
External issue ID: 5995

 Description   

This is the tracker bug for org.json removal:

  • org.json has a problematic license (at least for some of ODL's downstreams)
  • its integration in Jackson 2.4 and later causes issues in Karaf

 Comments   
Comment by Michael Vorburger [ 02/Jun/16 ]

ODLPARENT-36 created to make this happen in netconf. Let's create other bugs for specific code in other projects, and link them as "depends on" to this parent umbrella issue.

How about making the goal of this bug not only "reduce" but fully "remove" ? And then ultimately use http://maven.apache.org/enforcer/enforcer-rules/bannedDependencies.html to enforce future non-use of org.json?

Comment by Stephen Kitt [ 03/Jun/16 ]

The enforcer rule is ready, see https://git.opendaylight.org/gerrit/#/c/36537/8/odlparent/pom.xml

Comment by Stephen Kitt [ 13/Sep/16 ]

Projects which currently reference org.json in POMs or features are:

  • aaa
  • centinel
  • defense4all
  • iotdm
  • nemo
  • netconf (#5996)
  • ovsdb
  • sdninterfaceapp
  • sfc
  • vtn/coordinator
Comment by Stephen Kitt [ 23/Sep/16 ]

ovsdb: https://git.opendaylight.org/gerrit/46129

Comment by Stephen Kitt [ 23/Sep/16 ]

org.codehaus.jettison.json is also org.json, so we need to track that too.

Comment by Stephen Kitt [ 23/Sep/16 ]

SFC: https://git.opendaylight.org/gerrit/46140

Comment by Colin Dixon [ 06/Oct/16 ]

Per last week's TSC call: (see bullet 8)
https://meetings.opendaylight.org/opendaylight-meeting/2016/opendaylight_tsc/opendaylight-meeting-opendaylight_tsc.2016-09-29-15.03.html

I'm making this a blocker targeting Carbon.

Comment by Kit Lou [ 13/Sep/17 ]

What remains to be worked on this issue? My assumption is this does not block the nitrogen release. Correct?

Comment by Stephen Kitt [ 13/Sep/17 ]

(In reply to Kit Lou from comment #8)
> What remains to be worked on this issue? My assumption is this does not
> block the nitrogen release. Correct?

The target milestone is Fluorine, so no, it doesn’t block the Nitrogen release.

Comment by OpenDaylight Release [ 03/May/18 ]

Since this is not a blocker I'm removing the severity to critical. 

Comment by OpenDaylight Release [ 03/May/18 ]

Hmm, got it wrong.

Stephen, do you see this as a blocker for Fluorine? 

Comment by Stephen Kitt [ 03/May/18 ]

This was a TSC decision, we need to discuss it... Note that this is really a tracker bug, the bugs which need action are the blockers.

Comment by Robert Varga [ 07/Mar/19 ]

So this is just AAA and NETCONF now, let's kill the declaration in odplarent and have the two projects hash it out.

Generated at Wed Feb 07 20:27:27 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.