[ODLPARENT-37] Make karaf-plugin examine also non-feature dependencies Created: 08/Jun/16  Updated: 24/Jan/18  Resolved: 06/Sep/16

Status: Resolved
Project: odlparent
Component/s: General
Affects Version/s: None
Fix Version/s: None

Type: Bug
Reporter: Vratko Polak Assignee: Unassigned
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All


External issue ID: 6029

 Description   

See comments here: https://git.opendaylight.org/gerrit/35558



 Comments   
Comment by Vratko Polak [ 09/Jun/16 ]

> See comments

Looking back, there are many comments, so here is a summary relevant for this Bug.

Patch set 4 [0] was resulting in a karaf distributions (lispflowmapping one was used as test), which were missing the 1.0.5 version of org.apache.aries.proxy.impl even though it was listed as dependency in lines 97-103.

Looking at code of karaf-plugin, I have noticed that it filters out dependencies which are not features, that is why the dependency did not make it into the resulting karaf package and karaf then failes on startup, as lines 358-362 put the new version to startup.properties.

From patch set 5 [1] on, this Bug is circumvented by putting org.apache.aries.proxy.impl jar into a feature, so that karaf-plugin sees it and adds it into the distribution. But that feels like a hack, not a real solution.

But it would be much easier if karaf-plugin also recognized non-feature dependencies.
Alternatively, copy-dependencies goal of maven-dependency-plugin may remain required, with karaf-plugin only being there to cover the remaining blind spots.

[0] https://git.opendaylight.org/gerrit/#/c/35558/4
[1] https://git.opendaylight.org/gerrit/#/c/35558/5

Comment by Vratko Polak [ 06/Sep/16 ]

Since https://git.opendaylight.org/gerrit/43260
karaf-pluging packs in everything needed (and un-needed too, but that is another issue).

Generated at Wed Feb 07 20:27:27 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.