[ODLPARENT-55] add git.properties to boron Created: 13/Jan/17 Updated: 24/Jan/18 Resolved: 16/Feb/17 |
|
| Status: | Resolved |
| Project: | odlparent |
| Component/s: | General |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | ||
| Reporter: | Sam Hague | Assignee: | Unassigned |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
Operating System: All |
||
| External issue ID: | 7537 |
| Description |
|
git.properties is used to identify what gerrits are included in the distributions. The below gerrits have been identified so far as needed to be cherry-picked:
|
| Comments |
| Comment by Michael Vorburger [ 13/Jan/17 ] |
|
> gerrits have been identified so far https://git.opendaylight.org/gerrit/#/c/48447/ may be needed as a pre-req. as well; not sure > Were there patches on other projects, or just odlparent? see https://git.opendaylight.org/gerrit/#/q/message:48865
You would have to get the above two into usecplugin & sdninterfaceapp BEFORE doing the odlparent, to avoid breaking the build. |
| Comment by Michael Vorburger [ 26/Jan/17 ] |
|
> https://git.opendaylight.org/gerrit/#/c/49429/ maven-bundle-plugin in sdninterfaceapp cherry picked to stable/boron in https://git.opendaylight.org/gerrit/#/c/51028/ > https://git.opendaylight.org/gerrit/#/c/49446/ maven-bundle-plugin in usecplugin cherry picked to stable/boron in https://git.opendaylight.org/gerrit/#/c/51029/ |
| Comment by Michael Vorburger [ 26/Jan/17 ] |
|
Gerrits where Sam is cherry-picking related odlparent changes from master to stable/boron: |
| Comment by Michael Vorburger [ 09/Feb/17 ] |
|
This is now active, git.properties on stable/boron, the Gerrits listed above have been merged. There was an impact in at least 1 project which is worth recording here, in case it happens to others: [INFO] — maven-bundle-plugin:2.3.7:bundle (default-bundle) @ itm-impl — The key point here, easy to miss, is the exact version of the maven-bundle-plugin used... v2.3.7 is too old, and causes this issue, now that this merged. The fix, in case this happens to any other project, is to just remove any fixed <version> for the maven-bundle-plugin from any pom.xml, as done e.g. in https://git.opendaylight.org/gerrit/#/c/51547/1/itm/itm-impl/pom.xml This issue can probably be closed in the coming days, if no other unforeseen impacts come up. |
| Comment by Michael Vorburger [ 16/Feb/17 ] |
|
Done. |