[OPNFLWJAVA-69] Barrier Request not being set on both conditions triggered Created: 12/Jan/16  Updated: 19/Oct/17  Resolved: 12/Jan/16

Status: Resolved
Project: openflowjava
Component/s: General
Affects Version/s: unspecified
Fix Version/s: None

Type: Bug
Reporter: Michal Polkorab Assignee: Unassigned
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All


External issue ID: 4942

 Description   

Barrier request send mechanism in OutboundQueueManager is based on time and number of messages written.

If a barrier is scheduled - and there is another barrier written (because of exceeded number of messages written) between the time the first one was scheduled till it is sent - then the scheduled barrier is not sent. This happens due to the condition in scheduled barrier Runnable:

final long now = System.nanoTime();
final long sinceLast = now - lastBarrierNanos;
if (sinceLast >= maxBarrierNanos) {

  • the exceeded-number-of-messages barrier resets the lastBarrierNanos time, so the (sinceLast >= maxBarrierNanos) condition is false -> resulting in not sending the barrier


 Comments   
Comment by Michal Polkorab [ 12/Jan/16 ]

Change pushed here:
https://git.opendaylight.org/gerrit/#/c/32437/

Generated at Wed Feb 07 20:28:52 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.