[OPNFLWJAVA-78] Failed entries not freed from queue, causing superfluous iterations Created: 06/Sep/16  Updated: 14/Nov/17  Resolved: 13/Sep/16

Status: Resolved
Project: openflowjava
Component/s: General
Affects Version/s: unspecified
Fix Version/s: None

Type: Bug
Reporter: Andrej Leitner Assignee: Michal Polkorab
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All

External issue ID: 6638

 Description   

Entries in StackedSegment failAll method are failed and marked as completed but completeCount of segment is not incremented.

 Comments   
Comment by Andrej Leitner [ 06/Sep/16 ]

carbon: https://git.opendaylight.org/gerrit/#/c/45208/
boron: https://git.opendaylight.org/gerrit/#/c/45210/

Comment by Andrej Leitner [ 07/Sep/16 ]

merged in carbon

Comment by Tomas Slusny [ 08/Sep/16 ]

To add some more description to this issue:

Both succesfull and failed segments in queue are taken as completed, but failed segments are not freed from list of segments.
This can cause slower performance of queue when there are a lot of failed segments present, because of bigger lists to iterate.
This Andrej´s patch fixes this issue and properly marks failed segments as completed.

Comment by A H [ 08/Sep/16 ]

To better assess the impact of this bug and fix, could someone from your team please help us identify the following:
Severity: Could you elaborate on the severity of this bug? Is this a BLOCKER such that we cannot release Boron without it? Is there a workaround such that we can write a release note and fix in future Boron SR1?
Testing: Could you also elaborate on the testing of this patch? How extensively has this patch been tested? Is it covered by any unit tests or system tests?
Impact: Does this fix impact any dependent projects?

Comment by Abhijit Kumbhare [ 08/Sep/16 ]

(In reply to A H from comment #4)
> To better assess the impact of this bug and fix, could someone from your
> team please help us identify the following:
> Severity: Could you elaborate on the severity of this bug? Is this a
> BLOCKER such that we cannot release Boron without it? Is there a workaround
> such that we can write a release note and fix in future Boron SR1?
Yes: it is a blocker - especially looking at the description (that it can impact the performance after some time):
"Both successful and failed segments in queue are taken as completed, but failed segments are not freed from list of segments.

This can cause slower performance of queue when there are a lot of failed segments present, because of bigger lists to iterate.

Andrej´s patch fixes this issue and properly marks failed segments as completed."

> Testing: Could you also elaborate on the testing of this patch? How
> extensively has this patch been tested? Is it covered by any unit tests or
> system tests?
Luis, Andrej & Tomas have tested it well. Luis did not find any negative impact on the other projects. The performance code has good system tests - so it will be covered under the system tests.

> Impact: Does this fix impact any dependent projects?
OpenFlow Plugin is the dependent project. It should not impact projects dependent on OpenFlow Plugin.

Comment by Michal Polkorab [ 09/Sep/16 ]

both changes were merged

Comment by A H [ 10/Sep/16 ]

Has this bug been verified as fixed in the latest Boron RC 3.3 Build?

Comment by Andrej Leitner [ 13/Sep/16 ]

yes.

Generated at Wed Feb 07 20:28:53 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.