[OPNFLWJAVA-82] meterband structure inconsistent Created: 11/Dec/16  Updated: 19/Oct/17

Status: Open
Project: openflowjava
Component/s: General
Affects Version/s: unspecified
Fix Version/s: None

Type: Bug
Reporter: Huafei Zhang Assignee: Unassigned
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All

External issue ID: 7338

 Description   

Both MeterModInputMessageFactory and MultipartReplyMessageFactory deserialize meterband, but their MeterBand structure views differs.

MeterModInputMessageFactory.java has a line code like this:

actualLength += input.readUnsignedShort();

, so MeterBand structure view should be:

band type length xxx experimenter id ...
2 byte 2 byte 8 byte 4 byte

While MultipartReplyMessageFactory miss the code above, so MeterBand structure view is:

band type xxx experimenter id ...
2 byte 8 byte 4 byte


 Comments   
Comment by Huafei Zhang [ 11/Dec/16 ]

(In reply to Huafei Zhang from comment #0)
> Both MeterModInputMessageFactory and MultipartReplyMessageFactory
> deserialize meterband, but their MeterBand structure views differs.
>
> MeterModInputMessageFactory.java has a line code like this:
>
> actualLength += input.readUnsignedShort();
>
> , so MeterBand structure view should be:
>
> | band type | length | xxx | experimenter id | ...
> 2 byte 2 byte 8 byte 4 byte
>
> While MultipartReplyMessageFactory miss the code above, so MeterBand
> structure view is:
> | band type | xxx | experimenter id | ...
> 2 byte 8 byte 4 byte

MeterModInputMessageFactory refers to org.opendaylight.openflowjava.protocol.impl.deserialization.factories.MeterModInputMessageFactory

MultipartReplyMessageFactory refers to org.opendaylight.openflowjava.protocol.impl.deserialization.factories.MultipartReplyMessageFactory

Generated at Wed Feb 07 20:28:54 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.