[OPNFLWPLUG-1] NPE in during Handshake for OF 1.0 Created: 16/Nov/13  Updated: 27/Sep/21  Resolved: 18/Dec/13

Status: Resolved
Project: OpenFlowPlugin
Component/s: General
Affects Version/s: None
Fix Version/s: None

Type: Bug
Reporter: Ed Warnicke Assignee: Ed Warnicke
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: Mac OS
Platform: PC


External issue ID: 146
Priority: Normal

 Description   

Using the mininet from here:

https://wiki.opendaylight.org/view/OpenDaylight_OpenFlow_Plugin::End_to_End_Inventory

And running:

mininet@mininet-vm:~$ sudo mn --topo single,3 --controller 'remote,ip=192.168.195.1:6653' --switch ovsk,protocols=OpenFlow10

(to use OF 1.0).

Against the controller built in openflowplugin/distribution/base

I get the following NPE at the OSGI console:

2013-11-15 21:48:38.012 CST [pool-21-thread-1] ERROR o.o.o.o.md.core.HandshakeManagerImpl - issuing disconnect during handshake, reason: rpcError:null;
2013-11-15 21:48:38.013 CST [Thread-6] ERROR o.o.o.o.m.core.ErrorHandlerQueueImpl - IN THREAD: pool-21-thread-1; session:null -> null
java.lang.NullPointerException: null
at org.opendaylight.openflowplugin.openflow.md.core.session.OFSessionUtil.registerSession(OFSessionUtil.java:48) ~[na:na]
at org.opendaylight.openflowplugin.openflow.md.core.ConnectionConductorImpl.onHandshakeSuccessfull(ConnectionConductorImpl.java:335) ~[na:na]
at org.opendaylight.openflowplugin.openflow.md.core.HandshakeManagerImpl.postHandshake(HandshakeManagerImpl.java:300) ~[na:na]
at org.opendaylight.openflowplugin.openflow.md.core.HandshakeManagerImpl.handleLowerVersionProposal(HandshakeManagerImpl.java:150) ~[na:na]
at org.opendaylight.openflowplugin.openflow.md.core.HandshakeManagerImpl.handleStepByStepVersionNegotiation(HandshakeManagerImpl.java:131) ~[na:na]
at org.opendaylight.openflowplugin.openflow.md.core.HandshakeManagerImpl.run(HandshakeManagerImpl.java:103) ~[na:na]
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) ~[na:1.7.0_25]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) ~[na:1.7.0_25]
at java.lang.Thread.run(Thread.java:724) ~[na:1.7.0_25]
2013-11-15 21:48:38.013 CST [Thread-6] ERROR o.o.o.o.m.core.ErrorHandlerQueueImpl - IN THREAD: pool-21-thread-1; session:null -> rpcError:null;
java.lang.Exception: rpcError:null;
at org.opendaylight.openflowplugin.openflow.md.core.RpcUtil.smokeRpc(RpcUtil.java:34) ~[na:na]
at org.opendaylight.openflowplugin.openflow.md.core.HandshakeManagerImpl.postHandshake(HandshakeManagerImpl.java:289) ~[na:na]
at org.opendaylight.openflowplugin.openflow.md.core.HandshakeManagerImpl.handleStepByStepVersionNegotiation(HandshakeManagerImpl.java:121) ~[na:na]
at org.opendaylight.openflowplugin.openflow.md.core.HandshakeManagerImpl.run(HandshakeManagerImpl.java:103) ~[na:na]
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) ~[na:1.7.0_25]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) ~[na:1.7.0_25]
at java.lang.Thread.run(Thread.java:724) ~[na:1.7.0_25]

Additional data:
I see this bug against the following git id points:
For openflowplugin:

Macintosh-3:openflowplugin hagbard$ git log -2
commit 6771ee0a6bd328845d7a547affc5f0e45b000781
Author: Ed Warnicke <eaw@cisco.com>
Date: Wed Nov 13 17:35:37 2013 -0600

DO NOT MERGE YET - InventoryDataProviderUtils to make it easier
and clearer to interact with the data tree.

Change-Id: I8937b6b09cf22cce2fd9cf298147c278bf762c2b
Signed-off-by: Ed Warnicke <eaw@cisco.com>

commit b9324f06db0181557a35d19a36e75d304f7981d7
Author: HemaTG <hema.gopalkrishnan@ericsson.com>
Date: Fri Nov 15 21:05:49 2013 +0530

ModelDrivenSwitch for RPC and converter

Signed-off-by: HemaTG <hema.gopalkrishnan@ericsson.com>

For controller:

Macintosh-3:controller hagbard$ git log -2
commit 3c125cac9d91de5d1eefd27163ae1fc424a6d8ee
Merge: 72e582a 0a974a4
Author: Alessandro Boch <aboch@cisco.com>
Date: Fri Nov 15 22:39:48 2013 +0000

Merge "Modify the java-client to use the build-helper-maven-plugin"

commit 72e582a38f8700e0cef8780053f468ef8e64a3be
Author: Anil Vishnoi <avishnoi@in.ibm.com>
Date: Fri Nov 15 04:20:09 2013 +0530

MD-SAL Statistics Manager - Added sending request and caching response

Change-Id: I283a543a3a9e7ec3ea74c1018a82e51990ce03f9
Signed-off-by: Anil Vishnoi <avishnoi@in.ibm.com>

For integration:

Macintosh-3:integration hagbard$ git log -2
commit 3859a134df469f43f30e1d1f4365b1fd714d6e60
Author: Ed Warnicke <eaw@cisco.com>
Date: Thu Oct 31 11:56:51 2013 -0700

Adds OVSDB to Base - per TSC vote on Nov 7, 2013

Change-Id: I2b8bb22569077fc2c869f19a439b9dc0b93b9a77
Signed-off-by: Ed Warnicke <eaw@cisco.com>

commit 2b93f2b473f04810f1547291b13604a61f7bdd0e
Author: Baohua Yang <baohyang@cn.ibm.com>
Date: Thu Nov 7 17:06:35 2013 +0800

Init the test directory with CSIT_Test tool code.

Change-Id: I46ee41f58c0522de875b8784ea6f2ca599daa72f
Signed-off-by: Baohua Yang <baohyang@cn.ibm.com>



 Comments   
Comment by Michal Rehak [ 16/Nov/13 ]

OF-1.0 is not touching auxiliaryId - there is NULL left.
Fixed, see https://git.opendaylight.org/gerrit/#/c/2792/

Fixing this introduces a bunch of simple errors caused by differences between OF-1.0 and OF-1.3.

Comment by Michal Rehak [ 13/Dec/13 ]

Handshake under OF-1.0 has been fixed by https://git.opendaylight.org/gerrit/2792

subsequent errors regarding port update has been fixed by https://git.opendaylight.org/gerrit/3580

Please verify.

Generated at Wed Feb 07 20:31:18 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.