[OPNFLWPLUG-1048] ArbitratorReconciliationManagerImpl endReconciliation() never removes BundleDetails Created: 14/Nov/18 Updated: 15/Nov/18 Resolved: 15/Nov/18 |
|
| Status: | Resolved |
| Project: | OpenFlowPlugin |
| Component/s: | None |
| Affects Version/s: | Neon |
| Fix Version/s: | Oxygen-SR4, Fluorine-SR2, Neon |
| Type: | Bug | Priority: | Medium |
| Reporter: | Michael Vorburger | Assignee: | Michael Vorburger |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
While re-activating FindBugs on OFP in https://git.opendaylight.org/gerrit/#/c/77796/, I've stumbled upon a clear bug in ArbitratorReconciliationManagerImpl's endReconciliation() : It has a remove() on a Map which is very clearly of the wrong type - should be BigInteger but is InstanceIdentifier. What is the right way to fix that? |
| Comments |
| Comment by Michael Vorburger [ 14/Nov/18 ] |
| Comment by Michael Vorburger [ 14/Nov/18 ] |
|
> What is the right way to fix that? Avishnoi gobinath (gobinath@ericsson.com) hoping for your guidance here... |
| Comment by Anil Vishnoi [ 15/Nov/18 ] |
|
vorburger this is really a serious memory leak bug for the consumer using the bundle feature currently. Thanks for raising the bug. The fix that you pushed is a right fix, but can you please raise that as a separate patch rather than buried in the current findbug patch? Also that way we can do clean cherry-pick to other branches as well. |