[OPNFLWPLUG-1050] Make Grouping{Loose}Resolver immutatable Created: 15/Nov/18 Updated: 19/Dec/18 Resolved: 19/Dec/18 |
|
| Status: | Resolved |
| Project: | OpenFlowPlugin |
| Component/s: | General, nicira-extensions |
| Affects Version/s: | None |
| Fix Version/s: | Neon |
| Type: | Improvement | Priority: | Medium |
| Reporter: | Robert Varga | Assignee: | Anil Vishnoi |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Description |
|
Current of both GroupingResolver and GroupingLooseResolver are mutable, leading to sub-optimal execution as well as potential thread safety issues if they are modified while in use. Define proper immutable replacements, which will provide a builder-type instantiation, so that the internal implementation can use most optimal execution possible. |
| Comments |
| Comment by Michael Vorburger [ 16/Nov/18 ] |
|
rovarga does this have anything to do with / is motivated by any of the other bugs I recently raised? Like this wouldn't happen to be related to e.g. |
| Comment by Robert Varga [ 16/Nov/18 ] |
|
Not really, I just stubled on it while looking at that. It does change public API (MatchUtil), so it is not really a backport candidate in my mind. |
| Comment by Robert Varga [ 27/Nov/18 ] |
|
Avishnoi this has a patch proposed for quite some time. I am going offline and cannot drive it further. |