[OPNFLWPLUG-1053] Logs being spammed with org.opendaylight.openflowplugin.impl ConnectionEvent: Connection closed by device, Device:/127.0.0.1:38632, NodeId:null Created: 20/Nov/18  Updated: 27/Sep/21  Resolved: 28/Jan/19

Status: Resolved
Project: OpenFlowPlugin
Component/s: None
Affects Version/s: Oxygen-SR3
Fix Version/s: Fluorine-SR3, Neon

Type: Bug Priority: Medium
Reporter: Michael Vorburger Assignee: Michael Vorburger
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

We (downstream users of our ODL pased package) are getting reports of, quote:

ODL logs see 1000s of messages such as:

2018-11-13T18:23:12,192 | INFO | nioEventLoopGroup-9-90 | SystemNotificationsListenerImpl | 374 - org.opendaylight.openflowplugin.impl - 0.6.4.redhat-4 | ConnectionEvent: Connection closed by device, Device:/127.0.0.1:38632, NodeId:null

at a very high frequency, pretty much spamming logs.

This is in builds which are based on Oxygen.

Given that they are INFO and not WARN or ERROR, could we just lower these logs to DEBUG?

AvishnoiArunprakashgobinath, thapar, jhershbe - any thoughts?



 Comments   
Comment by Victor Pickard [ 20/Nov/18 ]

Pushed a patch to change log level to debug.

https://git.opendaylight.org/gerrit/#/c/77991/

Comment by Jamo Luhrsen [ 28/Nov/18 ]

this totally just ignores whatever problem is there that's causing this
spamming. why are we ending up in this state to start with. can we please
leave this jira open until the root cause is fixed, not just hidden with
a lower log level?

Comment by Anil Vishnoi [ 28/Nov/18 ]

We need to revert this patch, because it's not right fix. Connection and disconnection event will only be logged if the device connects or disconnects from the plugin, there is no other event in which case it will dump this log message. This is very basic logging that is required to track the device connection/disconnection from plugin, so we can't move it to debug level. Is there any karaf log that i can have a look at it ? I think this mostly probably the environment issue and some non-openflow process is trying to connect to 6633/6653 port from the local machine.

Comment by Tim Rozet [ 28/Nov/18 ]

The root cause of the issue was the way diagstatus was being done for OFP. It was consuming multiple new sockets per second, and then trying to connect then close the connection to ports 6633 and 6653. That's why there were so many messages in karaf about connections inbound from 127.0.0.1 and tons of connection adapters being created. I proposed a better solution that fixes the problem:

https://git.opendaylight.org/gerrit/#/c/78274/

Comment by Michael Vorburger [ 12/Dec/18 ]

Removing Oxygen SR4 from the Fix Versions list, as we missed that train here.

Comment by Michael Vorburger [ 06/Jan/19 ]

Arunprakash (d.arunprakash@ericsson.com ?), gobinath (gobinath@ericsson.com ?), Avishnoi : Happy New Year! Would you have a moment this week to review and hopefully merge https://git.opendaylight.org/gerrit/#/c/78675 and https://git.opendaylight.org/gerrit/#/c/78677 so that we can wrap up this issue? Thanks!

Comment by Arunprakash D [ 08/Jan/19 ]

Merged in master. Are you planning to bring it in stable/flourine as well?

Comment by Anil Vishnoi [ 08/Jan/19 ]

Arunprakash I was trying to test this locally to see if it resolves the original issue for which we changed the log level in the following patch https://git.opendaylight.org/gerrit/#/c/77991/

 

I just reverted this patch to revert the previous INFO logging level here https://git.opendaylight.org/gerrit/#/c/79299/. Can you please review this as well and merge?

 

Comment by Arunprakash D [ 08/Jan/19 ]

Avishnoi merged both the review (master and stable/fluorine)

Comment by Michael Vorburger [ 11/Jan/19 ]

> Merged in master. Are you planning to bring it in stable/flourine as well?

Arunprakash sure, done in https://git.opendaylight.org/gerrit/#/c/79451 and https://git.opendaylight.org/gerrit/79452 .. can you merge them and close this JIRA?

Comment by Michael Vorburger [ 12/Jan/19 ]

see also OPNFLWPLUG-1054

Generated at Wed Feb 07 20:34:04 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.