[OPNFLWPLUG-185] checkOdAction method of TestFromSalConversionsUtils class doesn't use third parameter. Created: 10/Jun/14  Updated: 27/Sep/21  Resolved: 25/Jul/14

Status: Resolved
Project: OpenFlowPlugin
Component/s: General
Affects Version/s: None
Fix Version/s: None

Type: Bug
Reporter: Hideyuki Tai Assignee: Vaclav Demcak
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: Linux
Platform: PC

Issue Links:
Blocks
blocks OPNFLWPLUG-110 Milestone: AD-SAL Compatibility adapt... Resolved
External issue ID: 1178

 Description   

Please see the following file.

controller/opendaylight/md-sal/compatibility/sal-compatibility/src/test/java/org/opendaylight/controller/sal/compatibility/test/TestFromSalConversionsUtils.java

checkOdAction method is invoked by checkOdActions method as follows.

224 private void checkOdActions(
225 List<org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.list.Action> actions)

{ 226 checkOdAction(actions, FloodActionCase.class, false); 227 checkOdAction(actions, FloodAllActionCase.class, false); 228 checkOdAction(actions, HwPathActionCase.class, false); 229 checkOdAction(actions, LoopbackActionCase.class, false); 230 checkOdAction(actions, PopVlanActionCase.class, false); 231 checkOdAction(actions, PushVlanActionCase.class, true); 232 checkOdAction(actions, SetDlDstActionCase.class, true); 233 checkOdAction(actions, SetDlSrcActionCase.class, true); 234 checkOdAction(actions, SetDlTypeActionCase.class, true); 235 checkOdAction(actions, SetNwTosActionCase.class, true); 236 checkOdAction(actions, SetNwDstActionCase.class, true); 237 checkOdAction(actions, SetNwSrcActionCase.class, true); 238 checkOdAction(actions, SetNextHopActionCase.class, true); 239 checkOdAction(actions, SetTpDstActionCase.class, true); 240 checkOdAction(actions, SetTpSrcActionCase.class, true); 241 checkOdAction(actions, SetVlanCfiActionCase.class, true); 242 checkOdAction(actions, SetVlanIdActionCase.class, true); 243 checkOdAction(actions, SetVlanPcpActionCase.class, true); 244 checkOdAction(actions, SwPathActionCase.class, false); 245 }

However, checkOdAction method doesn't use its third parameter at all.

[The code I checked]

I checked the latest code of controller project on 10th June.

odc180 $ git log -3 --oneline
16fcdf1 Merge changes I057476f2,I5b8602e7
9ba0d83 Merge "CONTROLLER-549: ContainerFlow boundary is not always enforced for vlans"
43d9468 BUG-981: Fix XML serialization test

 Comments   
Comment by Jan Hajnar [ 15/Jul/14 ]

https://git.opendaylight.org/gerrit/#/c/9005/

Generated at Wed Feb 07 20:31:47 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.