[OPNFLWPLUG-209] HW switch connection to fail - multiple handshakes started. Created: 04/Jul/14  Updated: 27/Sep/21  Resolved: 12/Aug/14

Status: Resolved
Project: OpenFlowPlugin
Component/s: General
Affects Version/s: None
Fix Version/s: None

Type: Bug
Reporter: Luis Gomez Assignee: James Gregory Hall
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: Linux
Platform: PC


External issue ID: 1310

 Description   

When we connect HW OF switch to controller, we observe controller sends feature request once, switch answers with feature reply and controller registers the switch, however after that controller re-sends feature request and after receiving features for second time it resets the connection because of "duplicate data path-id".

Here is the wireshark traces:

https://www.dropbox.com/s/o5ieepiiyqk3xp4/mlx-of10-odl-test.pcap.2?dl=1

And the controller log:

2014-07-02 11:23:47.236 PDT [OFHandshake-0-0] TRACE o.o.o.o.m.core.HandshakeManagerImpl - handshake STARTED
2014-07-02 11:23:47.244 PDT [OFHandshake-0-0] DEBUG o.o.o.o.m.core.HandshakeManagerImpl - sending hello message: version4, xid=21, version bitmap=[false, true, false, false, true]
2014-07-02 11:23:47.293 PDT [OFHandshake-0-0] DEBUG o.o.o.o.m.core.HandshakeManagerImpl - FIRST HELLO sent.
2014-07-02 11:23:47.293 PDT [OFHandshake-0-0] TRACE o.o.o.o.m.core.HandshakeManagerImpl - ret - firstHello+wait
2014-07-02 11:23:47.293 PDT [OFHandshake-0-0] TRACE o.o.o.o.m.core.HandshakeManagerImpl - handshake STARTED
2014-07-02 11:23:47.294 PDT [OFHandshake-0-0] DEBUG o.o.o.o.m.core.HandshakeManagerImpl - Hello message: version=1, bitmap=null, xid=562
2014-07-02 11:23:47.294 PDT [OFHandshake-0-0] DEBUG o.o.o.o.m.core.HandshakeManagerImpl - remoteVersion:1 lastProposedVersion:4, highestVersion:4
2014-07-02 11:23:47.294 PDT [OFHandshake-0-0] DEBUG o.o.o.o.m.core.HandshakeManagerImpl - sending hello message: version1, xid=563, version bitmap=[false, true, false, false, true]
2014-07-02 11:23:47.304 PDT [OFHandshake-0-0] DEBUG o.o.o.o.m.core.HandshakeManagerImpl - FIRST HELLO sent.
2014-07-02 11:23:47.304 PDT [OFHandshake-0-0] TRACE o.o.o.o.m.core.HandshakeManagerImpl - ret - sent+OK
2014-07-02 11:23:47.304 PDT [OFHandshake-0-0] DEBUG o.o.o.o.m.core.HandshakeManagerImpl - version set: 1
2014-07-02 11:23:47.306 PDT [OFHandshake-0-0] DEBUG o.o.o.o.m.core.HandshakeManagerImpl - sending feature request for version=1 and xid=564
2014-07-02 11:23:47.311 PDT [OFHandshake-0-0] DEBUG o.o.o.o.m.core.HandshakeManagerImpl - waiting for features
2014-07-02 11:23:47.338 PDT [OFHandshake-0-0] DEBUG o.o.o.o.m.core.HandshakeManagerImpl - obtained features: datapathId=14721743935839928320
2014-07-02 11:23:47.338 PDT [OFHandshake-0-0] DEBUG o.o.o.o.m.core.HandshakeManagerImpl - obtained features: auxiliaryId=null
2014-07-02 11:23:47.339 PDT [OFHandshake-0-0] TRACE o.o.o.o.m.core.HandshakeManagerImpl - handshake SETTLED: version=1, datapathId=14721743935839928320, auxiliaryId=null
2014-07-02 11:23:47.636 PDT [OFHandshake-0-0] DEBUG o.o.o.o.m.core.HandshakeManagerImpl - postHandshake DONE
2014-07-02 11:23:47.637 PDT [OFHandshake-0-0] TRACE o.o.o.o.m.core.HandshakeManagerImpl - handshake STARTED
2014-07-02 11:23:47.637 PDT [OFHandshake-0-0] DEBUG o.o.o.o.m.core.HandshakeManagerImpl - Hello message: version=1, bitmap=null, xid=563
2014-07-02 11:23:47.637 PDT [OFHandshake-0-0] DEBUG o.o.o.o.m.core.HandshakeManagerImpl - remoteVersion:1 lastProposedVersion:1, highestVersion:4
2014-07-02 11:23:47.637 PDT [OFHandshake-0-0] DEBUG o.o.o.o.m.core.HandshakeManagerImpl - version set: 1
2014-07-02 11:23:47.637 PDT [OFHandshake-0-0] DEBUG o.o.o.o.m.core.HandshakeManagerImpl - sending feature request for version=1 and xid=564
2014-07-02 11:23:47.639 PDT [OFHandshake-0-0] DEBUG o.o.o.o.m.core.HandshakeManagerImpl - waiting for features
2014-07-02 11:23:47.858 PDT [OFHandshake-0-0] DEBUG o.o.o.o.m.core.HandshakeManagerImpl - obtained features: datapathId=14721743935839928320
2o2014-07-02 11:23:47.859 PDT [OFHandshake-0-0] DEBUG o.o.o.o.m.c.session.OFSessionUtil - registering sessionKey: [0, -52, 78, 36, 28, 74, 0, 0, 0]
2014-07-02 11:23:47.859 PDT [OFHandshake-0-0] WARN o.o.o.o.m.c.session.OFSessionUtil - duplicate datapathId occured while registering new switch session: cc4e241c4a000000
2014-07-02 11:23:47.859 PDT [OFHandshake-0-0] TRACE o.o.o.o.m.c.ConnectionConductorImpl - disconnecting: sessionCtx=org.opendaylight.openflowplugin.openflow.md.core.session.SessionContextOFImpl@68ded0f8|auxId=null
2014-07-02 11:23:47.861 PDT [OFHandshake-0-0] WARN o.o.o.p.i.c.ResponseExpectedRpcListener - Request for RpcResultKey [xid=564, outputClazz=org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731.GetFeaturesOutput] did not receive a response
2014-07-02 11:23:47.862 PDT [OFHandshake-0-0] DEBUG o.o.o.o.m.c.s.SessionManagerOFImpl - removing session: [0, -52, 78, 36, 28, 74, 0, 0, 0]
2014-07-02 11:23:47.883 PDT [request-monitor] DEBUG o.o.o.o.m.c.s.ModelDrivenSwitchImpl - Prepare flow table statistics request to get flow table stats for all tables from node NodeRef [_value=KeyedInstanceIdentifier

{targetType=interface org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.nodes.Node, path=[org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.Nodes, org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.nodes.Node[key=NodeKey [_id=Uri [_value=openflow:14721743935839928320]]]]}

]- Transaction id - 3
014-07-02 11:23:47.858 PDT [OFHandshake-0-0] DEBUG o.o.o.o.m.core.HandshakeManagerImpl - obtained features: auxiliaryId=null
2014-07-02 11:23:47.858 PDT [OFHandshake-0-0] TRACE o.o.o.o.m.core.HandshakeManagerImpl - handshake SETTLED: version=1, datapathId=14721743935839928320, auxiliaryId=null



 Comments   
Comment by James Gregory Hall [ 08/Jul/14 ]

https://git.opendaylight.org/gerrit/#/c/8819/

Comment by James Gregory Hall [ 10/Jul/14 ]

I've found a simple fix to this issue ... after refactoring the code so that I understand it finally

https://git.opendaylight.org/gerrit/#/c/8900/

Comment by Abhijit Kumbhare [ 12/Aug/14 ]

From Greg's comments - this is fixed. If that's not true - please reopen it James.

Comment by Luis Gomez [ 12/Aug/14 ]

This is fixed yes.

Generated at Wed Feb 07 20:31:51 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.