[OPNFLWPLUG-289] Wrong values in IP ToS bits match field for OF 1.0 Created: 20/Sep/14  Updated: 27/Sep/21  Resolved: 01/Oct/14

Status: Resolved
Project: OpenFlowPlugin
Component/s: General
Affects Version/s: None
Fix Version/s: None

Type: Bug
Reporter: Hideyuki Tai Assignee: Hideyuki Tai
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All

External issue ID: 1994

 Description   

I've observed that the MD-SAL OF plugin set wrong values in IP ToS bits match field of FLOW_MOD messages for OpenFlow 1.0 switch.
On the other hand, it works correctly for OpenFlow 1.3 switches.

It seems to me that the OF plugin set DSCP value into ofp_match.nw_tos, although it must use the TOS (DSCP << 2) value.

[How to reproduce the problem]

Please try to install flow entry which has IP ToS bits match field.

Method: PUT

URL:
http://od-ip-address:8080/controller/nb/v2/flowprogrammer/default/node/OF/00:00:00:00:00:00:00:01/staticFlow/flow1

Message Body:
{ "installInHw":"true", "name":"flow1", "node":

{"id":"00:00:00:00:00:00:00:01","type":"OF"}

,"ingressPort":"1","priority":"500","tosBits":"3","actions":["SET_NW_TOS=1"] }

 Comments   
Comment by Michal Rehak [ 29/Sep/14 ]

https://git.opendaylight.org/gerrit/#/c/11661/

Comment by Michal Rehak [ 29/Sep/14 ]

Hideyuki, please retest.

Comment by Hideyuki Tai [ 30/Sep/14 ]

(In reply to michal rehak from comment #2)
> Hideyuki, please retest.

Hi Michal,

Thank you for submitting the patch.
https://git.opendaylight.org/gerrit/#/c/11661/

I could not make time to test the patch.
But, my colleague has tested the patch, and confirmed that your patch fixes the bug.

Comment by Michal Rehak [ 01/Oct/14 ]

merged

Generated at Wed Feb 07 20:32:04 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.