[#OPNFLWPLUG-29] Please convert System.out.println usage to proper log statements

[OPNFLWPLUG-29] Please convert System.out.println usage to proper log statements Created: 15/Jan/14 Updated: 27/Sep/21 Resolved: 15/Jan/14
Status:	Resolved
Project:	OpenFlowPlugin
Component/s:	General
Affects Version/s:	None
Fix Version/s:	None

Type:

Improvement

Reporter:

Ed Warnicke

Assignee:

Deepankar Gupta

Resolution:

Done

Votes:

Labels:

None

Remaining Estimate:

Not Specified

Time Spent:

Not Specified

Original Estimate:

Not Specified

Environment:

Operating System: Mac OS
Platform: PC

Description

Please convert System.out.println usage to proper log statements

Subdir openflowplugin/
Running command: grep -rn System.out .
./test-provider/src/main/java/org/opendaylight/openflowplugin/test/OpenflowpluginMeterTestCommandProvider.java:99: ./test-provider/src/main/java/org/opendaylight/openflowplugin/test/OpenflowpluginMeterTestCommandProvider.java:100: ./test-provider/src/main/java/org/opendaylight/openflowplugin/test/OpenflowpluginMeterTestCommandProvider.java:101: ./test-provider/src/main/java/org/opendaylight/openflowplugin/test/OpenflowpluginMeterTestCommandProvider.java:106: ./test-provider/src/main/java/org/opendaylight/openflowplugin/test/OpenflowpluginMeterTestCommandProvider.java:107: ./test-provider/src/main/java/org/opendaylight/openflowplugin/test/OpenflowpluginMeterTestCommandProvider.java:108: ./test-provider/src/main/java/org/opendaylight/openflowplugin/test/OpenflowpluginMeterTestCommandProvider.java:113: ./test-provider/src/main/java/org/opendaylight/openflowplugin/test/OpenflowpluginMeterTestCommandProvider.java:114: ./test-provider/src/main/java/org/opendaylight/openflowplugin/test/OpenflowpluginMeterTestCommandProvider.java:115: ./test-provider/src/main/java/org/opendaylight/openflowplugin/test/OpenflowpluginTestCommandProvider.java:239: ./test-provider/src/main/java/org/opendaylight/openflowplugin/test/OpenflowpluginTestCommandProvider.java:240: ./test-provider/src/main/java/org/opendaylight/openflowplugin/test/OpenflowpluginTestCommandProvider.java:241: ./test-provider/src/main/java/org/opendaylight/openflowplugin/test/OpenflowpluginTestCommandProvider.java:247: ./test-provider/src/main/java/org/opendaylight/openflowplugin/test/OpenflowpluginTestCommandProvider.java:248: ./test-provider/src/main/java/org/opendaylight/openflowplugin/test/OpenflowpluginTestCommandProvider.java:249: ./test-provider/src/main/java/org/opendaylight/openflowplugin/test/OpenflowpluginTestCommandProvider.java:255: ./test-provider/src/main/java/org/opendaylight/openflowplugin/test/OpenflowpluginTestCommandProvider.java:256: ./test-provider/src/main/java/org/opendaylight/openflowplugin/test/OpenflowpluginTestCommandProvider.java:258: ./test-provider/src/main/java/org/opendaylight/openflowplugin/test/OpenflowpluginTestCommandProvider.java:264: ./test-provider/src/main/java/org/opendaylight/openflowplugin/test/OpenflowpluginTestCommandProvider.java:266: ./test-provider/src/main/java/org/opendaylight/openflowplugin/test/OpenflowpluginTestCommandProvider.java:277: ./test-provider/src/main/java/org/opendaylight/openflowplugin/test/OpenflowpluginTestCommandProvider.java:279: ./test-provider/src/main/java/org/opendaylight/openflowplugin/test/OpenflowpluginTestCommandProvider.java:293: ./test-provider/src/main/java/org/opendaylight/openflowplugin/test/OpenflowpluginTestCommandProvider.java:294: ./test-provider/src/main/java/org/opendaylight/openflowplugin/test/OpenflowpluginTestCommandProvider.java:295: ./test-provider/src/main/java/org/opendaylight/openflowplugin/test/OpenflowpluginTestCommandProvider.java:301: ./test-provider/src/main/java/org/opendaylight/openflowplugin/test/OpenflowpluginTestCommandProvider.java:302: ./test-provider/src/main/java/org/opendaylight/openflowplugin/test/OpenflowpluginTestCommandProvider.java:303: ./test-provider/src/main/java/org/opendaylight/openflowplugin/test/OpenflowpluginTestCommandProvider.java:309: ./test-provider/src/main/java/org/opendaylight/openflowplugin/test/OpenflowpluginTestCommandProvider.java:310: ./test-provider/src/main/java/org/opendaylight/openflowplugin/test/OpenflowpluginTestCommandProvider.java:311: ./test-provider/src/main/java/org/opendaylight/openflowplugin/test/OpenflowpluginTestCommandProvider.java:317: ./test-provider/src/main/java/org/opendaylight/openflowplugin/test/OpenflowpluginTestCommandProvider.java:318: ./test-provider/src/main/java/org/opendaylight/openflowplugin/test/OpenflowpluginTestCommandProvider.java:319: System.out.println("Meter to be added.........................."+notification.toString());
System.out.println("Meter Xid........................."+notification.getTransactionId().getValue());
System.out.println("-----------------------------------------------------------------------------------");
System.out.println("Meter to be removed.........................."+notification.toString());
System.out.println("Meter Xid........................."+notification.getTransactionId().getValue());
System.out.println("-----------------------------------------------------------------------------------");
System.out.println("Meter to be updated.........................."+notification.toString());
System.out.println("Meter Xid........................."+notification.getTransactionId().getValue());
System.out.println("-----------------------------------------------------------------------------------");
System.out.println("flow to be added.........................." + notification.toString());
System.out.println("added flow Xid........................." + notification.getTransactionId().getValue());
System.out.println("-----------------------------------------------------------------------------------");
System.out.println("removed flow.........................." + notification.toString());
System.out.println("remove flow Xid........................." + notification.getTransactionId().getValue());
System.out.println("-----------------------------------------------------------------------------------");
System.out.println("updated flow.........................." + notification.toString());
System.out
System.out.println("-----------------------------------------------------------------------------------");
System.out.println("Error notification flow Xid........................."
System.out.println("-----------------------------------------------------------------------------------");
System.out
System.out.println("-----------------------------------------------------------------------------------");
System.out.println("NodeConnectorRemoved Notification ...................");
System.out.println(notification.getNodeConnectorRef());
System.out.println("----------------------------------------------------------------------");
System.out.println("NodeConnectorUpdated Notification...................");
System.out.println(notification.getNodeConnectorRef());
System.out.println("----------------------------------------------------------------------");
System.out.println("NodeConnectorUpdated Notification ...................");
System.out.println(notification.getNodeRef());
System.out.println("----------------------------------------------------------------------");
System.out.println("NodeConnectorUpdated Notification ...................");
System.out.println(notification.getNodeRef());
System.out.println("----------------------------------------------------------------------");

Comments

Comment by Anil Gujele [ 15/Jan/14 ]

It is fixed. pls refer for changes.
https://git.opendaylight.org/gerrit/#/c/4248/

Generated at Wed Feb 07 20:31:23 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.

[OPNFLWPLUG-29] Please convert System.out.println usage to proper log statements Created: 15/Jan/14 Updated: 27/Sep/21 Resolved: 15/Jan/14