[OPNFLWPLUG-295] Drop Rate and Drop burst size crossed in METER MOD message Created: 24/Sep/14  Updated: 27/Sep/21  Resolved: 11/Nov/14

Status: Resolved
Project: OpenFlowPlugin
Component/s: General
Affects Version/s: None
Fix Version/s: None

Type: Bug
Reporter: Luis Gomez Assignee: Devin Avery
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: Linux
Platform: PC


External issue ID: 2061

 Description   

I am pushing this meter mod:

http://localhost:8181/restconf/config/opendaylight-inventory:nodes/node/openflow:14721743935839928320/meter/2

<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<meter xmlns="urn:opendaylight:flow:inventory">
<flags>meter-kbps</flags>
<meter-band-headers>
<meter-band-header>
<band-id>0</band-id>
<drop-rate>10</drop-rate>
<drop-burst-size>500</drop-burst-size>
<meter-band-types>
<flags>ofpmbt-drop</flags>
</meter-band-types>
</meter-band-header>
</meter-band-headers>
<meter-id>2</meter-id>
<meter-name>Foo</meter-name>
</meter>

However this is what is really pushed:

http://localhost:8181/restconf/operational/opendaylight-inventory:nodes/node/openflow:14721743935839928320/meter/2

"flow-node-inventory:meter": [
{
"meter-id": 2,
"opendaylight-meter-statistics:meter-config-stats": {
"meter-id": 2,
"meter-band-headers": {
"meter-band-header": [
{
"band-id": 0,
"band-rate": 500,
"meter-band-types":

{ "flags": "ofpmbt-drop" }

,
"band-burst-size": 10,
"drop-rate": 500,
"drop-burst-size": 10
}
]
}
},

We can appreciate rate and burst-size are croossed is the meter mod. I also confirmed this bug with wireshark.

BR/Luis



 Comments   
Comment by Devin Avery [ 24/Sep/14 ]

Confirmed in code that these values are swapped. I can only assume by mistake.

Fixing tests to catch and fixing code.

Comment by Devin Avery [ 24/Sep/14 ]

https://git.opendaylight.org/gerrit/11511 pushed.

Generated at Wed Feb 07 20:32:05 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.