[OPNFLWPLUG-296] Unset fields in MeterStatsResponseConvertor Created: 24/Sep/14  Updated: 27/Sep/21  Resolved: 11/Nov/14

Status: Verified
Project: OpenFlowPlugin
Component/s: General
Affects Version/s: None
Fix Version/s: None

Type: Bug
Reporter: Michal Polkorab Assignee: Martin Bobak
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All

External issue ID: 2065

 Description   

I discovered two bugs while creating unit tests for MultipartReplyTranslator (MeterConfig case - please see MultipartReplyTranslatorFifthTest#testMeterConfigStats()).

#1:
In MeterStatsResponseConvertor#toSALMeterConfigList() the meterConfigStatsBuilder.setFlags() is not set. So the flags return null instead of boolean value.

#2:
In MeterStatsResponseConvertor#toSALMeterConfigList(), in case of a band of type MeterBandDscpRemarkCase is received, dscpRemarkBuilder.setPercLevel() is not set either (+ just typo - should be PrecLevel())

 Comments   
Comment by Martin Bobak [ 30/Oct/14 ]

Fixed in these two commits :

https://git.opendaylight.org/gerrit/#/c/12382/

https://git.opendaylight.org/gerrit/#/c/12381/

Generated at Wed Feb 07 20:32:05 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.