[OPNFLWPLUG-302] MatchConvertorImpl.OfMatchToSALMatchConvertor() converts OF13 match into incorrect MD-SAL match. Created: 01/Oct/14  Updated: 27/Sep/21  Resolved: 02/Oct/14

Status: Resolved
Project: OpenFlowPlugin
Component/s: General
Affects Version/s: None
Fix Version/s: None

Type: Bug
Reporter: Shigeru Yasuda Assignee: Unassigned
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All


External issue ID: 2126

 Description   

I found 2 bugs in MatchConvertorImpl.OfMatchToSALMatchConvertor().

1. MatchConvertorImpl.OfMatchToSALMatchConvertor() converts a switch port number
in IN_PORT match field into NodeConnectorId which contains only a logical port
name. But it should be converted into NodeConnectorId which contains a URI
of the specified port.

For example, if 3 is configured in IN_PORT match field and DPID is 1,
a string to be passed to constructor of NodeConnectorId is "openflow:1:3",
not "3".

2. Although CFI bit in VLAN_VID match field needs to be copied into MD-SAL match,
MatchConvertorImpl.OfMatchToSALMatchConvertor() does not.

Because of these bugs, openflowplugin generates incorrect OF13 flow statistics.
I wrote a patch and verified that it fixed this issue.



 Comments   
Comment by Shigeru Yasuda [ 01/Oct/14 ]

https://git.opendaylight.org/gerrit/11692

Generated at Wed Feb 07 20:32:06 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.