As per my understanding, There are code changes required from controller and plugin side.
Controller side:
Currently controller does not support to query the Queue for node connector and add queue to the node connector. So queue list is not found for the node connector in controller even if queue is added in Switch.
Plugin Side:
ModelDrivenSwitch.java does not implement interface SalQueueService.java to support queue , So interface implementation for queue support is missing.
Queue reply is also not yet implemented to attach the Queue to node connector.
As per my understanding, There are code changes required from controller , plugin and Yang model side. i am not good with Yang and Controller side, so pls assign it to controller team.
Yang Model:
Queue Model at controller side (GetQueueOutput.java Or QueueGetConfigReply.java) supports port:queue mapping as 1:1
Queue Model at plugin side (GetQueueConfigOutput.java) supports port:queue mapping as 1:n
Controller side:
Currently controller does not support to query the Queue for node connector and add queue to the node connector. So queue list is not found for the node connector in controller even if queue is added in Switch.
Plugin Side:
ModelDrivenSwitch.java does not implement interface SalQueueService.java to support queue , So interface implementation for queue support is missing.
Queue reply is also not yet implemented to attach the Queue to node connector.
Anil - Ed said there were changes made to the controller - which may be fixing this and wanted it retested.
Retested this issue and found that it is still happening.
Below test code can be use to recheck the issue.
Test code to reproduce this issue.
public void testQueue()
{
List<Node> nodes = getNodes();
for (Iterator<Node> iterator = nodes.iterator(); iterator.hasNext()
{
NodeKey nodeKey = iterator.next().getKey();
InstanceIdentifier<Node> nodeRef = InstanceIdentifier.builder(Nodes.class).child(Node.class, nodeKey)
.toInstance();
Node node = (Node) dataProviderService.readOperationalData(nodeRef);
List<NodeConnector> ports = node.getNodeConnector();
for (Iterator<NodeConnector> iterator2 = ports.iterator(); iterator2.hasNext() {
NodeConnectorKey nodeConnectorKey = iterator2.next().getKey();
InstanceIdentifier<FlowCapableNodeConnector> connectorRef = InstanceIdentifier.builder(Nodes.class)
.child(Node.class, nodeKey).child(NodeConnector.class, nodeConnectorKey)
.augmentation(FlowCapableNodeConnector.class).toInstance();
FlowCapableNodeConnector nodeConnector = (FlowCapableNodeConnector) dataProviderService
.readOperationalData(connectorRef);
// queue list is always empty, OPNFLWPLUG-31 is raised.
List<Queue> queueList = nodeConnector.getQueue();
for (Iterator<Queue> iterator3 = queueList.iterator(); iterator3.hasNext()
}
}
}
Hi AnilG,
This bug seems to be similar to OPNFLWPLUG-33. Where you can access the group statistics when you fetch data for /node/openflow:1 but it throws exception when you try to access the specific group like /node/openflow:1/group/1 using restconf. This is a bug (329) in yangtools which Martin Sunal is working on currently.
Similarly in this issue, To recreate the issue locally I created queue on node-connector:1 of the switch and then I fetch details of node-connector:1 using restconf, I do see queue statistics data in the response. Following is the snapshot of the restconf data
{
"node-connector": [
{
"flow-node-inventory:peer-features": "",
"flow-node-inventory:maximum-speed": 1048576,
"flow-node-inventory:state":
,
"id": "openflow:1:1",
"flow-node-inventory:port-number": 1,
"flow-node-inventory:supported": "pause hundred-gb-fd hundred-mb-hd other copper hundred-mb-fd fiber",
"flow-node-inventory:advertised-features": "pause hundred-gb-fd hundred-mb-hd other copper hundred-mb-fd fiber",
"flow-node-inventory:name": "eth1",
"flow-node-inventory:current-speed": 0,
"flow-node-inventory:current-feature": "pause other",
"flow-node-inventory:hardware-address": "00:21:CC:BA:14:E4",
"flow-node-inventory:configuration": "",
"opendaylight-port-statistics:flow-capable-node-connector-statistics": {
"opendaylight-port-statistics:receive-over-run-error": 0,
"opendaylight-port-statistics:transmit-errors": 0,
"opendaylight-port-statistics:receive-drops": 0,
"opendaylight-port-statistics:receive-crc-error": 0,
"opendaylight-port-statistics:duration":
,
"opendaylight-port-statistics:packets":
,
"opendaylight-port-statistics:receive-frame-error": 0,
"opendaylight-port-statistics:receive-errors": 0,
"opendaylight-port-statistics:transmit-drops": 0,
"opendaylight-port-statistics:bytes":
,
"opendaylight-port-statistics:collision-count": 0
},
"flow-node-inventory:queue": [
{
"flow-node-inventory:queue-id": 1,
"opendaylight-queue-statistics:flow-capable-node-connector-queue-statistics": {
"opendaylight-queue-statistics:duration":
,
"opendaylight-queue-statistics:transmitted-bytes": 0,
"opendaylight-queue-statistics:transmitted-packets": 0,
"opendaylight-queue-statistics:transmission-errors": 0
}
}
]
}
]
}
But when I tried to access the queue details of this node connector using following URI:
I am getting following exception ( similar to OPNFLWPLUG-33)
<b>exception</b>
<pre>java.lang.IllegalArgumentException
com.google.common.base.Preconditions.checkArgument(Preconditions.java:76)
org.opendaylight.controller.sal.restconf.impl.ControllerContext.addKeyValue(ControllerContext.java:787)
org.opendaylight.controller.sal.restconf.impl.ControllerContext.collectPathArguments(ControllerContext.java:672)
org.opendaylight.controller.sal.restconf.impl.ControllerContext.collectPathArguments(ControllerContext.java:688)
org.opendaylight.controller.sal.restconf.impl.ControllerContext.collectPathArguments(ControllerContext.java:688)
org.opendaylight.controller.sal.restconf.impl.ControllerContext.collectPathArguments(ControllerContext.java:688)
org.opendaylight.controller.sal.restconf.impl.ControllerContext.toInstanceIdentifier(ControllerContext.java:170)
org.opendaylight.controller.sal.restconf.impl.RestconfImpl.readOperationalData(RestconfImpl.java:215)
I believe when you are trying to get the queues programmatically, you are hitting the same bug. I will discuss this issue with Martin and will update you with further details.
Thanks
Anil
Thanks
Anil
Hi AnilG,
I discussed with Martin and this bug also seems to be causing because of yangtoolks bug – 329.
Thanks
Anil
Hi AnilG,
Dependent yangtools bug (bug -329) is now fixed, can you please verify that this fix resolves this issue.
Thanks
Anil
Hi AnilV,
I tested this issue with today's build, it is still not resolved.
Test code to reproduce this issue (after adding the queue as mention in defect description).
public void testQueue()
{
List<Node> nodes = getNodes();
for (Iterator<Node> iterator = nodes.iterator(); iterator.hasNext() {
NodeKey nodeKey = iterator.next().getKey();
InstanceIdentifier<Node> nodeRef = InstanceIdentifier.builder(Nodes.class).child(Node.class, nodeKey)
.toInstance();
Node node = (Node) dataProviderService.readOperationalData(nodeRef);
List<NodeConnector> ports = node.getNodeConnector();
for (Iterator<NodeConnector> iterator2 = ports.iterator(); iterator2.hasNext() {
NodeConnectorKey nodeConnectorKey = iterator2.next().getKey();
InstanceIdentifier<FlowCapableNodeConnector> connectorRef = InstanceIdentifier.builder(Nodes.class)
.child(Node.class, nodeKey).child(NodeConnector.class, nodeConnectorKey)
.augmentation(FlowCapableNodeConnector.class).toInstance();
FlowCapableNodeConnector nodeConnector = (FlowCapableNodeConnector) dataProviderService
.readOperationalData(connectorRef);
// queue list is always empty, OPNFLWPLUG-31 is raised.
List<Queue> queueList = nodeConnector.getQueue();
for (Iterator<Queue> iterator3 = queueList.iterator(); iterator3.hasNext()
}
}
}
Regards
ANil
Hi AnilG,
I followed the step you mentioned in the Description for creating queue and I tested this issue locally with the latest code from repo. When i directly fetch queue stats through RESTCONF, i am able to fetch the stats. I used following URI to fetch individual queue stats
Stats:
{
"flow-node-inventory:queue": [
{
"flow-node-inventory:queue-id": 0,
"opendaylight-queue-statistics:flow-capable-node-connector-queue-statistics": {
"opendaylight-queue-statistics:duration":
,
"opendaylight-queue-statistics:transmitted-bytes": 2331,
"opendaylight-queue-statistics:transmitted-packets": 37,
"opendaylight-queue-statistics:transmission-errors": 0
}
}
]
}
Can you please check by fetching queue/stats programmatically.
Thanks
AnilV
Hi AnilV,
Verified, Now programatically also we are able to get the queue list from the port if there is any queue is added for the port.
– ANil