[OPNFLWPLUG-311] MatchConvertorImpl bugs found during test creation Created: 30/Oct/14  Updated: 27/Sep/21  Resolved: 28/May/15

Status: Resolved
Project: OpenFlowPlugin
Component/s: General
Affects Version/s: None
Fix Version/s: None

Type: Bug
Reporter: Michal Polkorab Assignee: Martin Bobak
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All

Issue Links:
Blocks
blocks CONTROLLER-1342 Uncaught error from thread [opendayli... Resolved
External issue ID: 2280

 Description   

While creating tests for MatchConvertorImpl I discovered few bugs. Bugs can bee seen here https://git.opendaylight.org/gerrit/#/c/11668/ as TODO and FIXME and commented lines.

1. mask computation of PbbIsid match entry (both ways) - wrong mask lengths

  • PbbIsid mask length is 3

2. add mask computation for ArpSpa and ArpTpa match entries

  • mask conversion is missing for these fields

3. finish implementation of vlan vid match entry

  • isVlanIdPresent() is not set

 Comments   
Comment by Martin Bobak [ 09/Dec/14 ]

1st part is solved by this commit : https://git.opendaylight.org/gerrit/#/c/13450/

Comment by Jozef Gloncak [ 26/Jan/15 ]

patch set for poing 3 is proposed:
https://git.opendaylight.org/gerrit/#/c/14440/

Comment by Jozef Gloncak [ 26/Jan/15 ]

remark to point 3.

it seems that in MatchConvertorImpl.OfMatchToSALMatchConvertor() is in section with VlanVid.class set also _vlanIdPresent attribute.
there is chain vlanBuilder.setVlanId(....).setVlanIdPresent().

Comment by Michal Polkorab [ 26/Jan/15 ]

I agree. Point 3. seems like it has been fixed.

Comment by Jozef Gloncak [ 26/Jan/15 ]

I passed throu Michal's commit and searched for commented codes, FIXMEs, TODOs.

It was possible to uncomment almost all of them. See patch set:

https://git.opendaylight.org/gerrit/14482

Comment by Jozef Gloncak [ 27/Jan/15 ]

In MatchConvertorImplV13Test.testWithMatchEntriesWithMasks() it is necessary remove commented assertsEquals for checking equality masks of ethernet source and destination addresses.

Comment by Jozef Gloncak [ 27/Jan/15 ]

Problem from comment 6 (MatchConvertorImplV13Test.testWithMatchEntriesWithMasks() commented test) was fixed with patch:
https://git.opendaylight.org/gerrit/14545

Generated at Wed Feb 07 20:32:08 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.