Operating System: All
Platform: All

Messagebus is not present / installed in CSIT so it should not be the cause, since it did not touched any codepath in openflowplugin

The second one is more potential, but API contract were preserved, which effectively means ad-sal compatibility was relying on some implementation detail.

Hi Tony, I am going to remove the adsal test for now to restore the system test and unblock integration openflow patches, let me know when this is fixed so that I can restore the adsal test.

Thanks/Luis

It seems to me that the root cause of this issue (OPNFLWPLUG-385) is in the sal-compatibility in the openflowplugin.git.

The sal-compatibility registers itself with MD-SAL as a DataChangeListener for "Nodes/Node".
On the registration, the sal-compatibility, however, sets DataChangeScope.BASE as the scope of the data change.

[legacy/sal-compatibility/src/main/java/org/opendaylight/openflowplugin/legacy/sal/compatibility/AbstractDataChangeListener.java]
113 protected void registrationListener(final DataBroker db, int i) {
114 try {
115 listenerRegistration = db.registerDataChangeListener(LogicalDatastoreType.OPERATIONAL,
116 getWildCardPath(), this, DataChangeScope.BASE);

Since the scope is BASE, MD-SAL does not notify the sal-compatibility of the data change of children and augmentation of "Nodes/Node".
Though the sal-compatibility needs the data in "FlowCapableNode", which is the augmentation of "Nodes/Node", to update Node information.

[legacy/sal-compatibility/src/main/java/org/opendaylight/openflowplugin/legacy/sal/compatibility/NodeDataChangeListener.java]
31 protected void add(InstanceIdentifier<Node> createKeyIdent, Node node) {
32 FlowCapableNode fcn = node.getAugmentation(FlowCapableNode.class);
33 if(fcn != null) {

Why did it work well before?
I guess that MD-SAL wrongly handled the "DataChangeScope.BASE", and it leaked data changes to listeners before the following patch was merged.
https://git.opendaylight.org/gerrit/#/c/16821
The leak might cover up the sal-compatibility issue.

I've submitted a patch to the openflowplugin.git.
https://git.opendaylight.org/gerrit/#/c/17727/
The patch changes the scope of the data change from BASE to SUBTREE.

In my machine, I observed that the patch fixed the issue (OPNFLWPLUG-385).
By the result, I'm convinced that the root cause of this issue (OPNFLWPLUG-385) is in the sal-compatibility.

Michal and Anil have +1-ed the change:

https://git.opendaylight.org/gerrit/#/c/17727/

Please do not close the bug - see Michal's comments on this (this is a temporary work around & actual fix needs to be done separately):

https://lists.opendaylight.org/pipermail/openflowplugin-dev/2015-April/002887.html

OK, just let me know when I should restore the adsal tests in the CI. For now I am verifying this patch with new patch test job:

https://jenkins.opendaylight.org/releng/view/integration/job/integration-patch-test-master/1/

BR/Luis

https://git.opendaylight.org/gerrit/#/c/17727/ merged

This bug is part of the project to Move all ADSAL associated component bugs to ADSAL