[OPNFLWPLUG-402] Openflowplugin manager doesn't use match extensions while comparing two flows Created: 16/Apr/15  Updated: 27/Sep/21  Resolved: 15/Jun/15

Status: Resolved
Project: OpenFlowPlugin
Component/s: General
Affects Version/s: None
Fix Version/s: None

Type: Bug
Reporter: Flavio Fernandes Assignee: Anil Vishnoi
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All


Issue Links:
Duplicate
is duplicated by OPNFLWPLUG-369 continuous WARN logs when using neutr... Resolved
External issue ID: 3005

 Description   

Openflowplugin manager doesn't use match extensions while comparing two flows

Because of that, the hashing statistics manager relies upon to make unique keys
is not able to distinguish between multiple rules that differ based on the match
extension – such as REG0. That is also compound by the fact that actions are not part of the hashing as well.

That causes bugs when we have rules like this:

cookie=0x0, duration=255.353s, table=110, n_packets=8, n_bytes=648, priority=16384,reg0=0x1,tun_id=0x1,dl_dst=01:00:00:00:00:00/01:00:00:00:00:00 actions=output:1,output:2
cookie=0x0, duration=256.115s, table=110, n_packets=9, n_bytes=1464, priority=16384,reg0=0x2,tun_id=0x1,dl_dst=01:00:00:00:00:00/01:00:00:00:00:00 actions=output:1

So statistics manager assign the same id internally to both the flows and that's causing the repeated error message about duplicate id.

Adding match extension in flow comparison is not trivial and we cannot implement it in this release.

Anil added a simple solution, where flow comparison now use
cookies as a one of the element for flow comparison, so application can use that do differentiate the flows.

Following openflowplugin patch has more details:
https://git.opendaylight.org/gerrit/#/c/18442/

This patch adds cookie value to the flows net-virt installs. Cookies value is associated with individual flow for it's life time.



 Comments   
Comment by Abhijit Kumbhare [ 08/Jun/15 ]

Anil,

Can you confirm if this is fixed?

Thanks,
Abhijit

Comment by Abhijit Kumbhare [ 15/Jun/15 ]

OVSDB are using a workaround (to use cookies). Adding more logic for flow comparisons (using match extensions) may impact performance.

Need to think through the solution & document the workaround in the release notes.

Generated at Wed Feb 07 20:32:22 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.