[OPNFLWPLUG-407] Echo response timeout needs be exported to configuration Created: 20/Apr/15  Updated: 27/Sep/21  Resolved: 02/Mar/16

Status: Resolved
Project: OpenFlowPlugin
Component/s: General
Affects Version/s: None
Fix Version/s: None

Type: Bug
Reporter: Tali Ben-Meir Assignee: Kamal Rameshan
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All

External issue ID: 3026

 Description   

When sending ECHO request, the ECHO response timeout is hard coded to 2000ms. It needs to be exported to configuration to enable quicker switch failure detection in local area networks.

 Comments   
Comment by Divya Sree [ 22/Apr/15 ]

Hi Ben-Meir,

Do you mean adding the echo response timeout to config.properties in disrtibution/karaf/target/assembly/etc ?

Comment by Tali Ben-Meir [ 27/Apr/15 ]

(In reply to Divya Sree from comment #1)
> Hi Ben-Meir,
>
> Do you mean adding the echo response timeout to config.properties in
> disrtibution/karaf/target/assembly/etc ?

I thought it could be placed in the openplugin configuration file 42-openflowplugin.xml

Comment by Divya Sree [ 28/Apr/15 ]

Yes, I already tried to export echo-request-timeout 2000 to 42-openflowplugin.xml similiar to switch-idle-timeout.

Thanks for your reply.

Comment by Deepika Burre [ 05/May/15 ]

Hi Ben-Meir,

We had exported ECHO response timeout out to configuration.
But in SystemNotificationsListnerImpl.java we hard coded the path of 42-openflowplugin.xml file to pick the data. Is it fine to hard code the .xml path.

Comment by Tali Ben-Meir [ 06/May/15 ]

(In reply to Deepika Burre from comment #4)
> Hi Ben-Meir,
>
> We had exported ECHO response timeout out to configuration.
> But in SystemNotificationsListnerImpl.java we hard coded the path of
> 42-openflowplugin.xml file to pick the data. Is it fine to hard code the
> .xml path.

Couldn't it be defined in openflow-switch-connection-provider-impl yang module similarly to switch-idle-timeout?

Comment by Michal Rehak [ 06/May/15 ]

Hi, we have new echo service ready. You need li-features of ofplugin in order to use it: https://wiki.opendaylight.org/view/OpenDaylight_OpenFlow_Plugin::LiProposal_dev_setup

Here is API description: https://wiki.opendaylight.org/view/OpenDaylight_OpenFlow_Plugin:YangModels (see sal-echo)

Here is url: http://localhost:8181/restconf/operations/sal-echo:send-echo

Here is POSTed data:
<input xmlns="urn:opendaylight:echo:service">
<node xmlns:inv="urn:opendaylight:inventory">/inv:nodes/inv:node[inv:id="openflow:1"]</node>
<data>aGVsbG8gYmFzZSA2NC4gaW5wdXQ=</data>
</input>

Comment by Kamal Rameshan [ 27/Feb/16 ]

https://git.opendaylight.org/gerrit/#/c/35498/

Comment by Jozef Bacigal [ 02/Mar/16 ]

Hotfix:

https://git.opendaylight.org/gerrit/#/c/35607/

Generated at Wed Feb 07 20:32:23 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.