[OPNFLWPLUG-452] ICMPv4 type/code in OF10 match are ignored. Created: 21/May/15  Updated: 27/Sep/21  Resolved: 27/May/15

Status: Resolved
Project: OpenFlowPlugin
Component/s: General
Affects Version/s: None
Fix Version/s: None

Type: Bug
Reporter: Shigeru Yasuda Assignee: Shigeru Yasuda
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All


External issue ID: 3328

 Description   

Although OF10 supports ICMP type/code match, openflowplugin always ignores icmpv4-match in MD-SAL match if OF protocol is OF10.

I tried to install a flow entry which drops ICMPv4 echo into OF10 switch.

PUT http://localhost:8080/restconf/config/opendaylight-inventory:nodes/opendaylight-inventory:node/openflow:1/flow-node-inventory:table/0/flow-node-inventory:flow/icmp_echo
{
"flow-node-inventory:flow": [
{
"id": "icmp_echo",
"idle-timeout": 0,
"hard-timeout": 0,
"table_id": 0,
"priority": 10,
"match": {
"ip-match":

{ "ip-protocol": 1 }

,
"icmpv4-match":

{ "icmpv4-type": 8, "icmpv4-code": 0 }

,
"ethernet-match": {
"ethernet-type":

{ "type": 2048 }

}
}
}
]
}

But both ICMP type and code were ignored.

mininet> dpctl dump-flows

      • s1 ------------------------------------------------------------------------
        NXST_FLOW reply (xid=0x4):
        cookie=0x0, duration=68.873s, table=0, n_packets=0, n_bytes=0, idle_age=68, priority=10,icmp actions=drop

ICMP type and code should be set as TP_SRC/TP_DST respectively into OF10 match like this.

mininet> dpctl dump-flows

      • s1 ------------------------------------------------------------------------
        NXST_FLOW reply (xid=0x4):
        cookie=0x0, duration=4.637s, table=0, n_packets=0, n_bytes=0, idle_age=4, priority=10,icmp,icmp_type=8,icmp_code=0 actions=drop


 Comments   
Comment by Shigeru Yasuda [ 21/May/15 ]

https://git.opendaylight.org/gerrit/20912

Comment by Michal Rehak [ 26/May/15 ]

merged, please retest and eventually mark as fixed.

Comment by Shigeru Yasuda [ 27/May/15 ]

I verified that TCP, UDP, and ICMPv4 match could be set into OF10 flow entry.

Generated at Wed Feb 07 20:32:31 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.