screenshot.jpg
[OPNFLWPLUG-482] Missing TunIPv4DstConverter Created: 03/Jun/15 Updated: 27/Sep/21 Resolved: 10/Jun/15 |
|
| Status: | Resolved |
| Project: | OpenFlowPlugin |
| Component/s: | General |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | ||
| Reporter: | Thomas Bachman | Assignee: | Jozef Gloncak |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
Operating System: All |
||
| Attachments: |
screenshot.jpg
|
| External issue ID: | 3569 |
| Priority: | High |
| Description |
|
In the package: org.opendaylight.openflowplugin.extension.vendor.nicira.convertor.match There's a TunIPv4SrcConvertor.java, but no corresponding TunIPv4DstConverter.java. I think this means that matches against the tunnel destination won't work. |
| Comments |
| Comment by Jozef Gloncak [ 04/Jun/15 ] |
|
Attachment screenshot.jpg has been added with description: screenshot of structure of package org.opendaylight.openflowplugin.extension.vendor.nicira.convertor.match |
| Comment by Jozef Gloncak [ 04/Jun/15 ] |
|
I can see TunIpv4DstConverter see enclosed attachment. |
| Comment by Thomas Bachman [ 05/Jun/15 ] |
|
I'm a bit confused by the screen shot, as it differs from mine by quite a bit. I pulled the latest source, did a git checkout stable/lithium, and took a screenshot of what I have: https://www.dropbox.com/s/ikoznbnuyt78l60/Screenshot%202015-06-05%2018.24.56.png?dl=0 There are quite a few differences – note the NSH extensions present in mine, as well as the absence of the one you're referencing. Can you provide the git hash and branch of the source tree you're using? |
| Comment by Jozef Gloncak [ 08/Jun/15 ] |
|
I was referencing stable/helium. |
| Comment by Thomas Bachman [ 08/Jun/15 ] |
|
That's odd – is there a reason this was removed after Helium? Or was it just moved? If it was removed, I think it should be added back in. |
| Comment by Abhijit Kumbhare [ 08/Jun/15 ] |
|
Thomas noted that this is not a blocker for GBP. This may be pushed to Beryllium if we run out of time. |
| Comment by Jozef Gloncak [ 09/Jun/15 ] |
|
I prepared this patch |
| Comment by Michal Rehak [ 09/Jun/15 ] |
|
Merged, |
| Comment by Jozef Gloncak [ 09/Jun/15 ] |
|
Thomas can you, please, retest. |
| Comment by Thomas Bachman [ 09/Jun/15 ] |
|
I'm not going to be able to retest this for a while. If the UTs pass, then that's good enough for me. |
| Comment by Jozef Gloncak [ 10/Jun/15 ] |
|
ok, so as Michal has written it had been merged. Once you will have time to test and you will see any problem with it please open new or reopen this one. Thanks. |