[OPNFLWPLUG-49] OnFlowRemoved notification contains no Node Created: 24/Jan/14  Updated: 27/Sep/21  Resolved: 21/Mar/14

Status: Resolved
Project: OpenFlowPlugin
Component/s: General
Affects Version/s: None
Fix Version/s: None

Type: Bug
Reporter: Michal Rehak Assignee: Basheeruddin Ahmed
Resolution: Cannot Reproduce Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: Linux
Platform: PC

External issue ID: 363

 Description   

I added and removed flow

#osgi console:
addMDFlow openflow:1 f54 0
removeMDFlow openflow:1 f54 0

And notification.getNode(); was null

2014-01-24 15:11:01.040 CET [md-sal-binding-notification-11] ERROR o.o.c.sal.binding.impl.NotifyTask - Unhandled exception thrown by listener: org.opend
java.lang.NullPointerException: null
at org.opendaylight.controller.sal.compatibility.NodeMapping.toADNode(NodeMapping.java:274) ~[na:na]
at org.opendaylight.controller.sal.compatibility.FlowProgrammerAdapter.onFlowRemoved(FlowProgrammerAdapter.java:201) ~[na:na]
at org.opendaylight.controller.sal.compatibility.FlowProgrammerAdapter$$Broker$ListenerInvoker.onNotification(FlowProgrammerAdapter$$Broker$List
at org.opendaylight.controller.sal.binding.impl.NotifyTask.call(NotifyTask.java:59) ~[na:na]
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334) ~[na:1.7.0_25]
at java.util.concurrent.FutureTask.run(FutureTask.java:166) ~[na:1.7.0_25]
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) ~[na:1.7.0_25]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) ~[na:1.7.0_25]
at java.lang.Thread.run(Thread.java:724) ~[na:1.7.0_25]

Used build: openflowplugin/distribution/base

 Comments   
Comment by Tony Tkacik [ 24/Jan/14 ]

MD-SAL when delivering notifications does not change content of notification,
plugin probably did not fill out node.

Comment by Basheeruddin Ahmed [ 21/Mar/14 ]

Tried on laptop (ubuntu 10.04) with the following test environment couldn't reproduce the issue hence marking it resolved-> "worksforme"

The environment I used

1. mininet 2.1
2. Open vSwitch version
–
ovs-ofctl (Open vSwitch) 2.1.0
Compiled Mar 20 2014 08:51:22
OpenFlow versions 0x1:0x4
—

3. Created network
sudo mn --topo single,3 --controller 'remote,ip=10.0.0.3,port=6653' --switch ovsk,protocols=OpenFlow13

4. Created flow as per the defect from the OSGI console
addMDFlow openflow:1 f54 0

and checked at the switch in mininet
------
$ sudo ovs-ofctl -O OpenFlow13 dump-flows s1
OFPST_FLOW reply (OF1.3) (xid=0x2):
cookie=0xa, duration=15.086s, table=0, n_packets=0, n_bytes=0, send_flow_rem priority=0 actions=CONTROLLER:65535
-------

5. removed the flow from the OSGi console
removeMDFlow openflow:1 f54 0

and checked at the switch in mininet and the flow was gone

$ sudo ovs-ofctl -O OpenFlow13 dump-flows s1
OFPST_FLOW reply (OF1.3) (xid=0x2):

6. Checked the logs and didn't find any exception as mentioned.

Generated at Wed Feb 07 20:31:26 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.