[OPNFLWPLUG-518] Flow Reconciliator does not account for flow-deletions when the switch connection is disrupted Created: 29/Jul/15 Updated: 27/Sep/21 Resolved: 25/Jan/16 |
|
| Status: | Resolved |
| Project: | OpenFlowPlugin |
| Component/s: | General |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | ||
| Reporter: | Pompina Singh | Assignee: | Muthukumaran Kothandaraman |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
Operating System: Linux |
||
| External issue ID: | 4062 |
| Priority: | High |
| Description |
|
Description - 1- After creating the test setup, Connected 2 swithes to the controller. Controller Test setup - Single-node testing Switch connected - 2 - OVS |
| Comments |
| Comment by Michal Rehak [ 29/Jul/15 ] |
|
Right - this is currently the default behavior. If there are already some flows/meters/groups on device when connection established then controller will just reflect those in DS/operational (flows will get an alien id - e.g. "#UF$TABLE*0-1") without touching them. This is especially useful in case of frequent controller restarts or device reconnections. There was plan for implementing feature of clean-up upon connection established but that should be active based on parameter. Unfortunately this was never implemented. |
| Comment by Pompina Singh [ 29/Jul/15 ] |
|
Thanks Michal for the response.But what if when the tcp connection between the controller and the switch gets severed, the existing flows on the controller are modified or deleted as per business logic of the application. Now when the switch connects back , we have additional/conflicting flows that might lead to traffic being black-holed or dropped.This might not be the desired scenario. Is there a plan for cleanup upon establishment feature, anytime in the future ? |
| Comment by Michal Rehak [ 29/Jul/15 ] |
|
I see. https://wiki.opendaylight.org/view/OpenDaylight_OpenFlow_Plugin:Lithium_Backlog I guess there is currently no plan for that. This shall be discussed on ofPlugin weekly meeting. |
| Comment by Michal Rehak [ 06/Aug/15 ] |
|
added to Beryllium potential items wiki |
| Comment by Abhijit Kumbhare [ 21/Sep/15 ] |
|
Muthu has picked this up. |
| Comment by Muthukumaran Kothandaraman [ 28/Sep/15 ] |
|
Gerrit - https://git.opendaylight.org/gerrit/#/c/27382/ - to be reviewed |
| Comment by Abhijit Kumbhare [ 09/Oct/15 ] |
|
Changed to waiting for review |
| Comment by Michal Rehak [ 12/Oct/15 ] |
|
Hi, in comment #2 there is also modification mentioned. I guess this is not covered in the proposal. What is the difference in result when comparing this strategy and simple device cleanup upon connected? |
| Comment by Muthukumaran Kothandaraman [ 12/Oct/15 ] |
|
Hi Michal, This is mainly to accommodate the case where we do not want to disturb the data-path of already installed flows. If we do a full clean-up, it can result in traffic-drop |
| Comment by Michal Rehak [ 12/Oct/15 ] |
|
Ok, |
| Comment by Muthukumaran Kothandaraman [ 12/Oct/15 ] |
|
Hi Michal, >> can this feature be turned on/off for session? >> Is there any specific reason why is this incorporated in FRM?
Hope we are in sync
|
| Comment by Muthukumaran Kothandaraman [ 12/Oct/15 ] |
|
Adding gerrit link for ready-reference |
| Comment by Muthukumaran Kothandaraman [ 19/Oct/15 ] |
|
Uploaded patch-set addressing Michal's comment of making the "stale-marking" function configurable via Config Subsystem |
| Comment by Abhijit Kumbhare [ 30/Oct/15 ] |
|
Michal - can you review? |
| Comment by Abhijit Kumbhare [ 01/Dec/15 ] |
|
Michal has reviewed this - it is good to merge (either Abhijit or Anil can merge). |
| Comment by Abhijit Kumbhare [ 25/Jan/16 ] |
|
Marked as fixed as the code change is merged. |