[OPNFLWPLUG-537] Logging improvement Created: 18/Aug/15  Updated: 27/Sep/21  Resolved: 16/Aug/16

Status: Resolved
Project: OpenFlowPlugin
Component/s: General
Affects Version/s: None
Fix Version/s: None

Type: Improvement
Reporter: Hariharan Sethuraman Assignee: Hariharan Sethuraman
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: Linux
Platform: PC

Issue Links:
Blocks
is blocked by OPNFLWPLUG-501 flows not removed from the switch whe... Resolved

 Description   

Today, when I have info for org.opendaylight.openflowplugin, it shows for connection but not for disconnection.
And when I set debug, i see good amount of loggings, but it is difficult to have logs, workspace to find out the given log for which device.

1) INFO: A connect and disconnect logs should be there in place
2) Any openflow plugin log, should print the node id
3) <please add specific requirements if you think any>

 Comments   
Comment by Hariharan Sethuraman [ 22/Sep/15 ]

Moving the defect under OFJ from OFP as the fix requires changes in OFJ. We can file a defect for logging improvement in OFP separately.

Adding logs on disconnect event and during the flush in OBQ. Taking the defect.

Comment by Michal Polkorab [ 23/Sep/15 ]

I believe that openflowjava's incomming / received connection logs are informative enough.

Similarly, it delegates the disconnect event notification into openflowplugin where it can be logged. So what is the concrete information you want to see in openflowjava logs ?

Comment by Hariharan Sethuraman [ 23/Sep/15 ]

(In reply to Michal Polkorab from comment #2)
> I believe that openflowjava's incomming / received connection logs are
> informative enough.
>
> Similarly, it delegates the disconnect event notification into
> openflowplugin where it can be logged. So what is the concrete information
> you want to see in openflowjava logs ?

Initially thought to add it in OFJ would help in a centralized place. Later realized the logs are sufficient after going through the OFJ code. I should move back this defect to OFP - reason is, when I enable debug for org.opendaylight.openflowjava, I see the karaf logs being rolled up fast.

Comment by Hariharan Sethuraman [ 23/Sep/15 ]

(In reply to Hariharan Sethuraman from comment #3)
> (In reply to Michal Polkorab from comment #2)
> > I believe that openflowjava's incomming / received connection logs are
> > informative enough.
> >
> > Similarly, it delegates the disconnect event notification into
> > openflowplugin where it can be logged. So what is the concrete information
> > you want to see in openflowjava logs ?
>
> Initially thought to add it in OFJ would help in a centralized place. Later
> realized the logs are sufficient after going through the OFJ code. I should
> move back this defect to OFP - reason is, when I enable debug for
> org.opendaylight.openflowjava, I see the karaf logs being rolled up fast.

Moved it. Thanks.

Comment by Jozef Bacigal [ 16/Mar/16 ]

We added a lot of logs with node id in clustering optimizations update. On debug level. Is it informative enough now ?

Comment by Shuva Jyoti Kar [ 04/May/16 ]

for the li-plugin:

https://git.opendaylight.org/gerrit/#/c/38274/

https://git.opendaylight.org/gerrit/#/c/38254/

Still working on a couple of more ones..will keep u posted

Comment by Shuva Jyoti Kar [ 15/May/16 ]

first one merged. second one pending

Comment by Jozef Bacigal [ 19/May/16 ]

Guys, why we creating errors instead of warnings. I thought we agreed to log errors only in case we can't continue and whole system should be terminated. And anyway we can see all warning in log, so I don't see any good reason to get errors. Many things are good in this patch but I am not sure about those errors.

Jozef

Comment by Shuva Jyoti Kar [ 19/May/16 ]

Hi Jozef,

As a guideline i have logged in error on all failures and wherever we are catching exceptions. since in a normal ODL dist running, (in case of warns), we donot see logs.
We need to enable the logs and recreate the scenario in any case of any failures.

thanks

Comment by Shuva Jyoti Kar [ 19/May/16 ]

Do let me know of your comments. Also mostly at all places not too much of context information is available to deduct any conclusion. Hence have added info in those places.

Comment by Andrej Leitner [ 20/Jul/16 ]

another patches:
https://git.opendaylight.org/gerrit/#/c/36452
https://git.opendaylight.org/gerrit/#/c/40783
https://git.opendaylight.org/gerrit/#/c/42127

Comment by Miroslav Macko [ 16/Aug/16 ]

Logging improved. If needed more actions, reopen or create new bug.

Generated at Wed Feb 07 20:32:45 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.